@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow menu items to be edited again
Summary:
Ref T12174. We now require that we can figure out a valid "edit mode" (global vs custom/personal) before we hit EditEngine. Since the EditEngine routes don't have an `itemID`, they would failu to figure out the mode and just 404.
Let the engine use `id` (from EditEngine) if `itemID` (from MenuEngine) isn't present in the route.
Test Plan:
- Edited some menu items on Home / Projects.
- (I think I tested this, then broke it, originally.)
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12174
Differential Revision: https://secure.phabricator.com/D17280
+7
+7
src/applications/search/engine/PhabricatorProfileMenuEngine.php
+7
src/applications/search/engine/PhabricatorProfileMenuEngine.php
···
130
130
}
131
131
132
132
$item_id = $request->getURIData('itemID');
133
+
134
+
// If we miss on the MenuEngine route, try the EditEngine route. This will
135
+
// be populated while editing items.
136
+
if (!$item_id) {
137
+
$item_id = $request->getURIData('id');
138
+
}
139
+
133
140
$item_list = $this->getItems();
134
141
135
142
$selected_item = null;