@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Maniphest - fix a bug when selecting all tasks and then dragging them around
Summary: Fixes T4006.
Test Plan: clicked "select all" and dragged around tasks. Noted the task remained selected as I re-ordered, thus keeping hte count accurate. Verified when I hit "batch edit" the right tasks showed up.
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Maniphest Tasks: T4006
Differential Revision: https://secure.phabricator.com/D7566
+16
-1
+12
webroot/rsrc/js/application/maniphest/behavior-batch-selector.js
+12
webroot/rsrc/js/application/maniphest/behavior-batch-selector.js
···
41
41
update();
42
42
};
43
43
44
+
var redraw = function (task) {
45
+
var selected = is_selected(task);
46
+
change(task, selected);
47
+
};
48
+
JX.Stratcom.listen(
49
+
'subpriority-changed',
50
+
null,
51
+
function (e) {
52
+
e.kill();
53
+
var data = e.getData();
54
+
redraw(data.task);
55
+
});
44
56
45
57
// Change all tasks to some state (used by "select all" / "clear selection"
46
58
// buttons).
+4
-1
webroot/rsrc/js/application/maniphest/behavior-subpriorityeditor.js
+4
-1
webroot/rsrc/js/application/maniphest/behavior-subpriorityeditor.js
···
57
57
var nodes = JX.$H(r.tasks).getFragment().firstChild;
58
58
var task = JX.DOM.find(nodes, 'li', 'maniphest-task');
59
59
JX.DOM.replace(node, task);
60
-
61
60
draggable.unlock();
61
+
JX.Stratcom.invoke(
62
+
'subpriority-changed',
63
+
null,
64
+
{ 'task' : task });
62
65
};
63
66
64
67
new JX.Workflow(config.uri, data)