@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Read POST data sightly earlier in request startup
Summary:
On instances, the "SiteSource" (for site config) pretty much copy-pastes the "read POST data" block because it needs to make some decisions based on POST data when handling inbound mail webhooks.
Move the upstream read a little earlier so we can get rid of this. Now that this step is separated and must happen before the profiler, there's no reason not to do it earlier.
Test Plan: POSTed some data across pages without issue, will remove duplicate code in upcoming change.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20073
+2
-2
+2
-2
src/aphront/configuration/AphrontApplicationConfiguration.php
+2
-2
src/aphront/configuration/AphrontApplicationConfiguration.php
···
109
109
110
110
PhabricatorStartup::beginStartupPhase('env.init');
111
111
112
+
self::readHTTPPOSTData();
113
+
112
114
try {
113
115
PhabricatorEnv::initializeWebEnvironment();
114
116
$database_exception = null;
···
151
153
'r' => $address_string,
152
154
'M' => idx($_SERVER, 'REQUEST_METHOD', '-'),
153
155
));
154
-
155
-
self::readHTTPPOSTData();
156
156
157
157
DarkConsoleXHProfPluginAPI::hookProfiler();
158
158