@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make minor flavor updates
Summary: Refresh the 404 text since it hasn't been updated in a while, and swap the "Save Query" button back to grey since I never got used to blue.
Test Plan: Hit 404 page, saved a query.
Differential Revision: https://secure.phabricator.com/D20734
+10
-6
+8
-5
src/aphront/response/Aphront404Response.php
+8
-5
src/aphront/response/Aphront404Response.php
···
8
8
9
9
public function buildResponseString() {
10
10
$request = $this->getRequest();
11
-
$user = $request->getUser();
11
+
$viewer = $request->getViewer();
12
12
13
13
$dialog = id(new AphrontDialogView())
14
-
->setUser($user)
14
+
->setViewer($viewer)
15
15
->setTitle(pht('404 Not Found'))
16
-
->addCancelButton('/', pht('Focus'))
16
+
->addCancelButton('/', pht('Return to Charted Waters'))
17
+
->appendParagraph(
18
+
pht(
19
+
'You arrive at your destination, but there is nothing here.'))
17
20
->appendParagraph(
18
21
pht(
19
-
'Do not dwell in the past, do not dream of the future, '.
20
-
'concentrate the mind on the present moment.'));
22
+
'Perhaps the real treasure was the friends you made '.
23
+
'along the way.'));
21
24
22
25
$view = id(new PhabricatorStandardPageView())
23
26
->setTitle(pht('404 Not Found'))
+2
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
+2
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
···
194
194
if ($run_query && !$named_query && $user->isLoggedIn()) {
195
195
$save_button = id(new PHUIButtonView())
196
196
->setTag('a')
197
+
->setColor(PHUIButtonView::GREY)
197
198
->setHref('/search/edit/key/'.$saved_query->getQueryKey().'/')
198
199
->setText(pht('Save Query'))
199
-
->setIcon('fa-floppy-o');
200
+
->setIcon('fa-bookmark');
200
201
$submit->addButton($save_button);
201
202
}
202
203