@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make legacy revision statuses from "differential.query" have type "string" again
Summary:
Ref T2543. The type on these got changed by accident, it should be "string" (crazy nonsense, compatible) not "int" (sensible, not compatible).
(New API uses sensible strings like "accepted" only.)
Test Plan: Called `differential.query` from web UI, saw `"2"` and similar statuses.
Reviewers: chad, jmeador, lvital
Reviewed By: jmeador, lvital
Maniphest Tasks: T2543
Differential Revision: https://secure.phabricator.com/D18493
+5
-1
+5
-1
src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
+5
-1
src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
···
218
218
'dateCreated' => $revision->getDateCreated(),
219
219
'dateModified' => $revision->getDateModified(),
220
220
'authorPHID' => $revision->getAuthorPHID(),
221
-
'status' => $revision->getLegacyRevisionStatus(),
221
+
222
+
// NOTE: For backward compatibility this is explicitly a string, like
223
+
// "2", even though the value of the string is an integer. See PHI14.
224
+
'status' => (string)$revision->getLegacyRevisionStatus(),
225
+
222
226
'statusName' => $revision->getStatusDisplayName(),
223
227
'properties' => $revision->getProperties(),
224
228
'branch' => $diff->getBranch(),