@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a rendering fatal for unknown edge constants
If we try to render an edge transaction which uses unknown edge constants,
it turns out we fatal. Degrade instead. This happened when viewing very old
badges.
Auditors: chad
+9
-1
+9
-1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+9
-1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
···
932
932
$type = $this->getMetadata('edge:type');
933
933
$type = head($type);
934
934
935
-
$type_obj = PhabricatorEdgeType::getByConstant($type);
935
+
try {
936
+
$type_obj = PhabricatorEdgeType::getByConstant($type);
937
+
} catch (Exception $ex) {
938
+
// Recover somewhat gracefully from edge transactions which
939
+
// we don't have the classes for.
940
+
return pht(
941
+
'%s edited an edge.',
942
+
$this->renderHandleLink($author_phid));
943
+
}
936
944
937
945
if ($add && $rem) {
938
946
return $type_obj->getTransactionEditString(