@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Phriction - fix edits with subscribers
Summary: pre-patch, these fatal, since we overwrite $content to be just a string so methods fail later in the code. Instead, write a $content_str to keep $content as the proper data.
Test Plan: editing a document and on save it showed me the view page! (as opposed to fataling and staying on the eidt page)
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D10426
+2
-2
+2
-2
src/applications/phriction/editor/PhrictionDocumentEditor.php
+2
-2
src/applications/phriction/editor/PhrictionDocumentEditor.php
···
264
264
}
265
265
266
266
if ($feed_action) {
267
-
$content = id(new PhutilUTF8StringTruncator())
267
+
$content_str = id(new PhutilUTF8StringTruncator())
268
268
->setMaximumGlyphs(140)
269
269
->truncateString($new_content->getContent());
270
270
id(new PhabricatorFeedStoryPublisher())
···
276
276
array(
277
277
'phid' => $document->getPHID(),
278
278
'action' => $feed_action,
279
-
'content' => $content,
279
+
'content' => $content_str,
280
280
'project' => $project_phid,
281
281
'movedFromPHID' => $this->fromDocumentPHID,
282
282
))