recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove non-existing min-device-pixel-ratio CSS syntax

Summary:
`min-device-pixel-ratio`/`device-pixel-ratio` do not exist.

For the records,
* Standard `min-resolution` has been supported since Firefox 16 released 08/2012, Opera 12.1 released 11/2012, Chromium 29 released 07/2013, and Edge 12 released 07/2015
* Safari 15.8 released 07/2022 still requires `-webkit-min-device-pixel-ratio`
* Non-standard `min--moz-device-pixel-ratio` syntax was supported from Firefox 4 to Firefox 15 according to https://developer.mozilla.org/en-US/docs/Web/CSS/@media/-moz-device-pixel-ratio

Test Plan:
* Run `/bin/celerity sprites`, check that icons on http://phorge.localhost/auth/config/new/ still render.
* Read CSS docs; probably install ancient browser versions if you don't trust documentation.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25972

Andre Klapper b5788540 de2b5363

+11 -14
+9 -9
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '79a197f6', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => '22e722fb', 12 + 'core.pkg.css' => '64703355', 13 13 'core.pkg.js' => '086da722', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '91ac6214', ··· 183 183 'rsrc/css/phui/workboards/phui-workboard.css' => 'e7ba21a7', 184 184 'rsrc/css/phui/workboards/phui-workcard.css' => '62056e3b', 185 185 'rsrc/css/phui/workboards/phui-workpanel.css' => 'c44f95c7', 186 - 'rsrc/css/sprite-login.css' => '07052ee0', 187 - 'rsrc/css/sprite-tokens.css' => 'f1896dc5', 186 + 'rsrc/css/sprite-login.css' => '0abdf921', 187 + 'rsrc/css/sprite-tokens.css' => '330edc9e', 188 188 'rsrc/css/syntax/syntax-default.css' => 'c0307dc6', 189 189 'rsrc/externals/d3/d3.min.js' => 'e97b4b78', 190 190 'rsrc/externals/font/fontawesome/fontawesome-webfont.eot' => '23f8c698', ··· 341 341 'rsrc/image/phrequent_active.png' => 'de66dc50', 342 342 'rsrc/image/phrequent_inactive.png' => '79c61baf', 343 343 'rsrc/image/resize.png' => '9cc83373', 344 - 'rsrc/image/sprite-login-X2.png' => '02896524', 345 - 'rsrc/image/sprite-login.png' => 'e0508107', 346 - 'rsrc/image/sprite-tokens-X2.png' => '21621dd9', 347 - 'rsrc/image/sprite-tokens.png' => 'bede2580', 344 + 'rsrc/image/sprite-login-X2.png' => 'e192f93d', 345 + 'rsrc/image/sprite-login.png' => '6c73e3ca', 346 + 'rsrc/image/sprite-tokens-X2.png' => '5ddc639b', 347 + 'rsrc/image/sprite-tokens.png' => '15f84535', 348 348 'rsrc/image/texture/card-gradient.png' => 'e6892cb4', 349 349 'rsrc/image/texture/dark-menu-hover.png' => '390a4fa1', 350 350 'rsrc/image/texture/dark-menu.png' => '542f699c', ··· 903 903 'project-triggers-css' => 'cd9c8bb9', 904 904 'project-view-css' => '567858b3', 905 905 'setup-issue-css' => '93231115', 906 - 'sprite-login-css' => '07052ee0', 907 - 'sprite-tokens-css' => 'f1896dc5', 906 + 'sprite-login-css' => '0abdf921', 907 + 'sprite-tokens-css' => '330edc9e', 908 908 'syntax-default-css' => 'c0307dc6', 909 909 'syntax-highlighting-css' => '548567f6', 910 910 'tokens-css' => 'ce5a50bd',
+1 -1
resources/sprite/manifest/login.json
··· 116 116 1, 117 117 2 118 118 ], 119 - "header": "/**\n * @provides sprite-login-css\n * @generated\n */\n\n.sprite-login {\n background-image: url(/rsrc/image/sprite-login.png);\n background-repeat: no-repeat;\n}\n\n@media\nonly screen and (min-device-pixel-ratio: 1.5),\nonly screen and (-webkit-min-device-pixel-ratio: 1.5),\nonly screen and (min-resolution: 1.5dppx) {\n .sprite-login {\n background-image: url(/rsrc/image/sprite-login-X2.png);\n background-size: {X}px {Y}px;\n }\n}\n", 119 + "header": "/**\n * @provides sprite-login-css\n * @generated\n */\n\n.sprite-login {\n background-image: url(/rsrc/image/sprite-login.png);\n background-repeat: no-repeat;\n}\n\n@media\nonly screen and (-webkit-min-device-pixel-ratio: 1.5),\nonly screen and (min-resolution: 1.5dppx) {\n .sprite-login {\n background-image: url(/rsrc/image/sprite-login-X2.png);\n background-size: {X}px {Y}px;\n }\n}\n", 120 120 "type": "standard" 121 121 }
+1 -1
resources/sprite/manifest/tokens.json
··· 126 126 1, 127 127 2 128 128 ], 129 - "header": "/**\n * @provides sprite-tokens-css\n * @generated\n */\n\n.sprite-tokens {\n background-image: url(/rsrc/image/sprite-tokens.png);\n background-repeat: no-repeat;\n}\n\n@media\nonly screen and (min-device-pixel-ratio: 1.5),\nonly screen and (-webkit-min-device-pixel-ratio: 1.5),\nonly screen and (min-resolution: 1.5dppx) {\n .sprite-tokens {\n background-image: url(/rsrc/image/sprite-tokens-X2.png);\n background-size: {X}px {Y}px;\n }\n}\n", 129 + "header": "/**\n * @provides sprite-tokens-css\n * @generated\n */\n\n.sprite-tokens {\n background-image: url(/rsrc/image/sprite-tokens.png);\n background-repeat: no-repeat;\n}\n\n@media\nonly screen and (-webkit-min-device-pixel-ratio: 1.5),\nonly screen and (min-resolution: 1.5dppx) {\n .sprite-tokens {\n background-image: url(/rsrc/image/sprite-tokens-X2.png);\n background-size: {X}px {Y}px;\n }\n}\n", 130 130 "type": "standard" 131 131 }
-1
src/applications/celerity/CeleritySpriteGenerator.php
··· 120 120 if ($has_retina) { 121 121 $retina_rules = <<<EOCSS 122 122 @media 123 - only screen and (min-device-pixel-ratio: 1.5), 124 123 only screen and (-webkit-min-device-pixel-ratio: 1.5), 125 124 only screen and (min-resolution: 1.5dppx) { 126 125 .sprite-{$name}{$extra_css} {
-1
webroot/rsrc/css/sprite-login.css
··· 9 9 } 10 10 11 11 @media 12 - only screen and (min-device-pixel-ratio: 1.5), 13 12 only screen and (-webkit-min-device-pixel-ratio: 1.5), 14 13 only screen and (min-resolution: 1.5dppx) { 15 14 .sprite-login {
-1
webroot/rsrc/css/sprite-tokens.css
··· 9 9 } 10 10 11 11 @media 12 - only screen and (min-device-pixel-ratio: 1.5), 13 12 only screen and (-webkit-min-device-pixel-ratio: 1.5), 14 13 only screen and (min-resolution: 1.5dppx) { 15 14 .sprite-tokens {
webroot/rsrc/image/sprite-login-X2.png

This is a binary file and will not be displayed.

webroot/rsrc/image/sprite-login.png

This is a binary file and will not be displayed.

webroot/rsrc/image/sprite-tokens-X2.png

This is a binary file and will not be displayed.

webroot/rsrc/image/sprite-tokens.png

This is a binary file and will not be displayed.