@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Stop evaluating Herald rules when writing "someone mentioned this somewhere else." transactions
Summary: Ref T13114. See PHI510. Firing Herald on mentioned objects tends to feel arbitrary and can substantially slow down edits which mention many objects.
Test Plan: Mentioned tasks on other tasks; verified that the normal path is hit normally, the new Herald-free path is hit on the mentioned object, and both still work fine and show up in the timeline.
Maniphest Tasks: T13114
Differential Revision: https://secure.phabricator.com/D19263
+5
+5
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+5
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
1120
1120
// We are the Herald editor, so stop work here and return the updated
1121
1121
// transactions.
1122
1122
return $xactions;
1123
+
} else if ($this->getIsInverseEdgeEditor()) {
1124
+
// Do not run Herald if we're just recording that this object was
1125
+
// mentioned elsewhere. This tends to create Herald side effects which
1126
+
// feel arbitrary, and can really slow down edits which mention a large
1127
+
// number of other objects. See T13114.
1123
1128
} else if ($this->shouldApplyHeraldRules($object, $xactions)) {
1124
1129
// We are not the Herald editor, so try to apply Herald rules.
1125
1130
$herald_xactions = $this->applyHeraldRules($object, $xactions);