@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Missing change from D5120 which I incorrectly discarded in a merge.
Auditors: vrana
+77
-14
+4
-4
src/__phutil_library_map__.php
+4
-4
src/__phutil_library_map__.php
···
1851
1851
'DifferentialPathFieldSpecification' => 'DifferentialFieldSpecification',
1852
1852
'DifferentialPeopleMenuEventListener' => 'PhutilEventListener',
1853
1853
'DifferentialPrimaryPaneView' => 'AphrontView',
1854
-
'DifferentialRemarkupRule' => 'PhabricatorRemarkupRuleObjectName',
1854
+
'DifferentialRemarkupRule' => 'PhabricatorRemarkupRuleObject',
1855
1855
'DifferentialReplyHandler' => 'PhabricatorMailReplyHandler',
1856
1856
'DifferentialResultsTableView' => 'AphrontView',
1857
1857
'DifferentialRevertPlanFieldSpecification' => 'DifferentialFieldSpecification',
···
2071
2071
'ManiphestEdgeEventListener' => 'PhutilEventListener',
2072
2072
'ManiphestExportController' => 'ManiphestController',
2073
2073
'ManiphestPeopleMenuEventListener' => 'PhutilEventListener',
2074
-
'ManiphestRemarkupRule' => 'PhabricatorRemarkupRuleObjectName',
2074
+
'ManiphestRemarkupRule' => 'PhabricatorRemarkupRuleObject',
2075
2075
'ManiphestReplyHandler' => 'PhabricatorMailReplyHandler',
2076
2076
'ManiphestReportController' => 'ManiphestController',
2077
2077
'ManiphestSavedQuery' => 'ManiphestDAO',
···
2604
2604
'PhabricatorPasteEditController' => 'PhabricatorPasteController',
2605
2605
'PhabricatorPasteListController' => 'PhabricatorPasteController',
2606
2606
'PhabricatorPasteQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
2607
-
'PhabricatorPasteRemarkupRule' => 'PhabricatorRemarkupRuleObjectName',
2607
+
'PhabricatorPasteRemarkupRule' => 'PhabricatorRemarkupRuleObject',
2608
2608
'PhabricatorPasteViewController' => 'PhabricatorPasteController',
2609
2609
'PhabricatorPeopleController' => 'PhabricatorController',
2610
2610
'PhabricatorPeopleEditController' => 'PhabricatorPeopleController',
···
3028
3028
'PonderQuestionQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
3029
3029
'PonderQuestionSummaryView' => 'AphrontView',
3030
3030
'PonderQuestionViewController' => 'PonderController',
3031
-
'PonderRemarkupRule' => 'PhabricatorRemarkupRuleObjectName',
3031
+
'PonderRemarkupRule' => 'PhabricatorRemarkupRuleObject',
3032
3032
'PonderReplyHandler' => 'PhabricatorMailReplyHandler',
3033
3033
'PonderSearchIndexer' => 'PhabricatorSearchDocumentIndexer',
3034
3034
'PonderUserProfileView' => 'AphrontView',
+15
-2
src/applications/differential/remarkup/DifferentialRemarkupRule.php
+15
-2
src/applications/differential/remarkup/DifferentialRemarkupRule.php
···
1
1
<?php
2
2
3
3
/**
4
-
* @group markup
4
+
* @group differential
5
5
*/
6
6
final class DifferentialRemarkupRule
7
-
extends PhabricatorRemarkupRuleObjectName {
7
+
extends PhabricatorRemarkupRuleObject {
8
8
9
9
protected function getObjectNamePrefix() {
10
10
return 'D';
11
+
}
12
+
13
+
protected function loadObjects(array $ids) {
14
+
$viewer = $this->getEngine()->getConfig('viewer');
15
+
16
+
if (!$viewer) {
17
+
return array();
18
+
}
19
+
20
+
return id(new DifferentialRevisionQuery())
21
+
->setViewer($viewer)
22
+
->withIDs($ids)
23
+
->execute();
11
24
}
12
25
13
26
}
+15
-2
src/applications/maniphest/remarkup/ManiphestRemarkupRule.php
+15
-2
src/applications/maniphest/remarkup/ManiphestRemarkupRule.php
···
1
1
<?php
2
2
3
3
/**
4
-
* @group markup
4
+
* @group maniphest
5
5
*/
6
6
final class ManiphestRemarkupRule
7
-
extends PhabricatorRemarkupRuleObjectName {
7
+
extends PhabricatorRemarkupRuleObject {
8
8
9
9
protected function getObjectNamePrefix() {
10
10
return 'T';
11
+
}
12
+
13
+
protected function loadObjects(array $ids) {
14
+
$viewer = $this->getEngine()->getConfig('viewer');
15
+
16
+
if (!$viewer) {
17
+
return array();
18
+
}
19
+
20
+
return id(new ManiphestTaskQuery())
21
+
->setViewer($viewer)
22
+
->withTaskIDs($ids)
23
+
->execute();
11
24
}
12
25
13
26
}
+15
-1
src/applications/paste/remarkup/PhabricatorPasteRemarkupRule.php
+15
-1
src/applications/paste/remarkup/PhabricatorPasteRemarkupRule.php
···
4
4
* @group markup
5
5
*/
6
6
final class PhabricatorPasteRemarkupRule
7
-
extends PhabricatorRemarkupRuleObjectName {
7
+
extends PhabricatorRemarkupRuleObject {
8
8
9
9
protected function getObjectNamePrefix() {
10
10
return 'P';
11
+
}
12
+
13
+
protected function loadObjects(array $ids) {
14
+
$viewer = $this->getEngine()->getConfig('viewer');
15
+
16
+
if (!$viewer) {
17
+
return array();
18
+
}
19
+
20
+
return id(new PhabricatorPasteQuery())
21
+
->setViewer($viewer)
22
+
->withIDs($ids)
23
+
->execute();
24
+
11
25
}
12
26
13
27
}
+28
-5
src/applications/ponder/remarkup/PonderRemarkupRule.php
+28
-5
src/applications/ponder/remarkup/PonderRemarkupRule.php
···
1
1
<?php
2
2
3
-
/**
4
-
* @group markup
5
-
*/
6
3
final class PonderRemarkupRule
7
-
extends PhabricatorRemarkupRuleObjectName {
4
+
extends PhabricatorRemarkupRuleObject {
8
5
9
6
protected function getObjectNamePrefix() {
10
-
return 'Q(?![1-4]\b)';
7
+
return 'Q';
8
+
}
9
+
10
+
protected function loadObjects(array $ids) {
11
+
$viewer = $this->getEngine()->getConfig('viewer');
12
+
13
+
if (!$viewer) {
14
+
return array();
15
+
}
16
+
17
+
return id(new PonderQuestionQuery())
18
+
->setViewer($viewer)
19
+
->withIDs($ids)
20
+
->execute();
11
21
}
22
+
23
+
protected function shouldMarkupObject(array $params) {
24
+
// NOTE: Q1, Q2, Q3 and Q4 are often used to refer to quarters of the year;
25
+
// mark them up only in the {Q1} format.
26
+
if ($params['type'] == 'ref') {
27
+
if ($params['id'] <= 4) {
28
+
return false;
29
+
}
30
+
}
31
+
32
+
return true;
33
+
}
34
+
12
35
}
13
36