@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Link to Herald transcripts from Herald transactions
Summary: See IRC. Some users are having difficulty figuring out why Herald is taking some actions. Make it easier to get to the transcript.
Test Plan: {F144622}
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: dctrwatson, epriestley
Differential Revision: https://secure.phabricator.com/D8804
+52
-2
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
147
147
'rsrc/css/phui/phui-status.css' => '2f562399',
148
148
'rsrc/css/phui/phui-tag-view.css' => '295d81c4',
149
149
'rsrc/css/phui/phui-text.css' => '23e9b4b7',
150
-
'rsrc/css/phui/phui-timeline-view.css' => '23fe340a',
150
+
'rsrc/css/phui/phui-timeline-view.css' => '17905388',
151
151
'rsrc/css/phui/phui-workboard-view.css' => '84f2c272',
152
152
'rsrc/css/phui/phui-workpanel-view.css' => '97b69459',
153
153
'rsrc/css/sprite-actions.css' => '969ad0e5',
···
762
762
'phui-status-list-view-css' => '2f562399',
763
763
'phui-tag-view-css' => '295d81c4',
764
764
'phui-text-css' => '23e9b4b7',
765
-
'phui-timeline-view-css' => '23fe340a',
765
+
'phui-timeline-view-css' => '17905388',
766
766
'phui-workboard-view-css' => '84f2c272',
767
767
'phui-workpanel-view-css' => '97b69459',
768
768
'policy-css' => '957ea14c',
+5
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+5
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
661
661
$herald_xactions = $this->applyHeraldRules($object, $xactions);
662
662
663
663
if ($herald_xactions) {
664
+
$xscript_id = $this->getHeraldTranscript()->getID();
665
+
foreach ($herald_xactions as $herald_xaction) {
666
+
$herald_xaction->setMetadataValue('herald:transcriptID', $xscript_id);
667
+
}
668
+
664
669
// NOTE: We're acting as the omnipotent user because rules deal with
665
670
// their own policy issues. We use a synthetic author PHID (the
666
671
// Herald application) as the author of record, so that transactions
+15
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+15
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
···
757
757
return true;
758
758
}
759
759
760
+
public function renderExtraInformationLink() {
761
+
$herald_xscript_id = $this->getMetadataValue('herald:transcriptID');
762
+
763
+
if ($herald_xscript_id) {
764
+
return phutil_tag(
765
+
'a',
766
+
array(
767
+
'href' => '/herald/transcript/'.$herald_xscript_id.'/',
768
+
),
769
+
pht('View Herald Transcript'));
770
+
}
771
+
772
+
return null;
773
+
}
774
+
760
775
761
776
/* -( PhabricatorPolicyInterface Implementation )-------------------------- */
762
777
+24
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
+24
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
···
190
190
pht('(Show Details)'));
191
191
}
192
192
193
+
private function buildExtraInformationLink(
194
+
PhabricatorApplicationTransaction $xaction) {
195
+
196
+
$link = $xaction->renderExtraInformationLink();
197
+
if (!$link) {
198
+
return null;
199
+
}
200
+
201
+
return phutil_tag(
202
+
'span',
203
+
array(
204
+
'class' => 'phui-timeline-extra-information',
205
+
),
206
+
array(" \xC2\xB7 ", $link));
207
+
}
208
+
193
209
protected function shouldGroupTransactions(
194
210
PhabricatorApplicationTransaction $u,
195
211
PhabricatorApplicationTransaction $v) {
···
313
329
);
314
330
}
315
331
}
332
+
333
+
if (!$this->isPreview) {
334
+
$more = $this->buildExtraInformationLink($xaction);
335
+
if ($more) {
336
+
$title = array($title, ' ', $more);
337
+
}
338
+
}
339
+
316
340
$event->setTitle($title);
317
341
}
318
342