@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use bracket-free, human-readable query URIs everywhere
Summary: See <http://fab.wmflabs.org/T88>. While this issue is on MW's side, these links are kind of ugly and have more readable alternate forms now. Update them to use proper modern forms.
Test Plan: See inlines.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D9042
+15
-37
+5
-1
src/__phutil_library_map__.php
+5
-1
src/__phutil_library_map__.php
···
3159
3159
'DiffusionPathValidateController' => 'DiffusionController',
3160
3160
'DiffusionPushEventViewController' => 'DiffusionPushLogController',
3161
3161
'DiffusionPushLogController' => 'DiffusionController',
3162
-
'DiffusionPushLogListController' => 'DiffusionPushLogController',
3162
+
'DiffusionPushLogListController' =>
3163
+
array(
3164
+
0 => 'DiffusionPushLogController',
3165
+
1 => 'PhabricatorApplicationSearchResultsControllerInterface',
3166
+
),
3163
3167
'DiffusionQuery' => 'PhabricatorQuery',
3164
3168
'DiffusionRawDiffQuery' => 'DiffusionQuery',
3165
3169
'DiffusionRepositoryController' => 'DiffusionController',
+1
-2
src/applications/differential/event/DifferentialActionMenuEventListener.php
+1
-2
src/applications/differential/event/DifferentialActionMenuEventListener.php
···
34
34
}
35
35
36
36
$person = $event->getValue('object');
37
-
$href = '/differential/?authorPHIDs[]='.$person->getPHID();
37
+
$href = '/differential/?authors='.$person->getUsername();
38
38
39
39
return id(new PhabricatorActionView())
40
-
->setRenderAsForm(true)
41
40
->setIcon('differential-dark')
42
41
->setIconSheet(PHUIIconView::SPRITE_APPS)
43
42
->setName(pht('View Revisions'))
+4
-4
src/applications/home/controller/PhabricatorHomeMainController.php
+4
-4
src/applications/home/controller/PhabricatorHomeMainController.php
···
148
148
'Nothing appears to be critically broken right now.');
149
149
}
150
150
151
-
$href = sprintf(
152
-
'/maniphest/?statuses[]=%s&priorities[]=%s#R',
151
+
$href = urisprintf(
152
+
'/maniphest/?statuses=%s&priorities=%s#R',
153
153
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
154
154
$unbreak_now);
155
155
$title = pht('Unbreak Now!');
···
196
196
}
197
197
198
198
$title = pht('Needs Triage');
199
-
$href = sprintf(
200
-
'/maniphest/?statuses[]=%s&priorities[]=%s&userProjects[]=%s#R',
199
+
$href = urisprintf(
200
+
'/maniphest/?statuses=%s&priorities=%s&userProjects=%s#R',
201
201
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
202
202
$needs_triage,
203
203
$user->getPHID());
+1
-1
src/applications/maniphest/controller/ManiphestReportController.php
+1
-1
src/applications/maniphest/controller/ManiphestReportController.php
···
442
442
}
443
443
}
444
444
445
-
$base_link = '/maniphest/?allProjects[]=';
445
+
$base_link = '/maniphest/?allProjects=';
446
446
$leftover_name = phutil_tag('em', array(), pht('(No Project)'));
447
447
$col_header = pht('Project');
448
448
$header = pht('Open Tasks by Project and Priority (%s)', $date);
-25
src/applications/maniphest/event/ManiphestActionMenuEventListener.php
-25
src/applications/maniphest/event/ManiphestActionMenuEventListener.php
···
44
44
->setHref($view_uri);
45
45
}
46
46
47
-
private function renderProjectItems(PhutilEvent $event) {
48
-
if (!$this->canUseApplication($event->getUser())) {
49
-
return null;
50
-
}
51
-
52
-
$project = $event->getValue('object');
53
-
54
-
$phid = $project->getPHID();
55
-
$view_uri = '/maniphest/?statuses[]=0&allProjects[]='.$phid.'#R';
56
-
$create_uri = '/maniphest/task/create/?projects='.$phid;
57
-
58
-
return array(
59
-
id(new PhabricatorActionView())
60
-
->setIcon('maniphest-dark')
61
-
->setIconSheet(PHUIIconView::SPRITE_APPS)
62
-
->setName(pht('View Tasks'))
63
-
->setHref($view_uri),
64
-
id(new PhabricatorActionView())
65
-
->setName(pht("Add Task"))
66
-
->setIcon('create')
67
-
->setHref($create_uri),
68
-
);
69
-
}
70
-
71
-
72
47
}
+3
-3
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
+3
-3
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
···
50
50
51
51
$saved->setParameter(
52
52
'allProjectPHIDs',
53
-
$request->getArr('allProjects'));
53
+
$this->readPHIDsFromRequest($request, 'allProjects'));
54
54
55
55
$saved->setParameter(
56
56
'withNoProject',
···
58
58
59
59
$saved->setParameter(
60
60
'anyProjectPHIDs',
61
-
$request->getArr('anyProjects'));
61
+
$this->readPHIDsFromRequest($request, 'anyProjects'));
62
62
63
63
$saved->setParameter(
64
64
'excludeProjectPHIDs',
65
-
$request->getArr('excludeProjects'));
65
+
$this->readPHIDsFromRequest($request, 'excludeProjects'));
66
66
67
67
$saved->setParameter(
68
68
'userProjectPHIDs',
+1
-1
src/applications/project/controller/PhabricatorProjectProfileController.php
+1
-1
src/applications/project/controller/PhabricatorProjectProfileController.php
···
148
148
149
149
$phid = $project->getPHID();
150
150
$view_uri = urisprintf(
151
-
'/maniphest/?statuses=%s&allProjects[]=%s#R',
151
+
'/maniphest/?statuses=%s&allProjects=%s#R',
152
152
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
153
153
$phid);
154
154
$create_uri = '/maniphest/task/create/?projects='.$phid;