@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue where the Maniphest burnup chart was trying to render a non-View object
Summary:
See PHI1714. This code is incorrectly rendering the chart panel twice, sort of, and passing a non-View object to rendering.
After D21044, this fatals by raising an exception in rendering.
Test Plan: Loaded page, no more exception.
Differential Revision: https://secure.phabricator.com/D21185
+3
-3
+3
-3
src/applications/maniphest/controller/ManiphestReportController.php
+3
-3
src/applications/maniphest/controller/ManiphestReportController.php
···
398
398
->setProjects($projects)
399
399
->buildChartPanel();
400
400
401
-
$chart_panel = $panel->setName(pht('Burnup Rate'));
401
+
$panel->setName(pht('Burnup Rate'));
402
402
403
403
$chart_view = id(new PhabricatorDashboardPanelRenderingEngine())
404
404
->setViewer($viewer)
405
-
->setPanel($chart_panel)
405
+
->setPanel($panel)
406
406
->setParentPanelPHIDs(array())
407
407
->renderPanel();
408
408
409
-
return array($filter, $chart_view, $panel);
409
+
return array($filter, $chart_view);
410
410
}
411
411
412
412
private function renderReportFilters(array $tokens, $has_window) {