@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Phriction feed stories text rendering
Summary: Fixes T3763. All this junk needs some actual fixing at some point, but stop it from fataling.
Test Plan: Used `feed.query` with `view=text`. Before this patch, Phriction stories fataled. Now they render reasonably.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T3763
Differential Revision: https://secure.phabricator.com/D6819
+3
-3
+3
-3
src/applications/feed/story/PhabricatorFeedStoryPhriction.php
+3
-3
src/applications/feed/story/PhabricatorFeedStoryPhriction.php
···
77
77
}
78
78
79
79
public function renderText() {
80
-
$author_phid = $this->getHandle($this->getAuthorPHID());
81
-
$author_link = $this->linkTo($author_phid);
80
+
$author_handle = $this->getHandle($this->getAuthorPHID());
81
+
$author_name = $author_handle->getName();
82
82
83
83
$document_handle = $this->getHandle($this->getPrimaryObjectPHID());
84
84
$document_title = $document_handle->getLinkName();
···
87
87
$action = $this->getValue('action');
88
88
$verb = PhrictionActionConstants::getActionPastTenseVerb($action);
89
89
90
-
$text = "{$author_link} {$verb} the document".
90
+
$text = "{$author_name} {$verb} the document".
91
91
" {$document_title} {$document_uri}";
92
92
93
93
return $text;