recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Show daemon arguments when launching a daemon with `./bin/phd`.

Summary: Ref T4735. When launching daemons (with `./bin/phd start` or `./bin/phd launch`), print the arguments that are specified for the daemon.

Test Plan:
Ran `./bin/phd launch repo -- --not X`.

```
> sudo ./bin/phd launch repo -- --not X
Preparing to launch daemons.
NOTE: Logs will appear in '/mnt/logs/phd/daemons.log'.

Launching daemon "PhabricatorRepositoryPullLocalDaemon" with arguments ["--not","X"].
```

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4735

Differential Revision: https://secure.phabricator.com/D9205

authored by

Joshua Spence and committed by
epriestley b6d15377 76dc959c

+25 -8
+25 -8
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
··· 99 99 $console = PhutilConsole::getConsole(); 100 100 101 101 if ($debug) { 102 - $console->writeOut( 103 - pht( 104 - 'Launching daemon "%s" in debug mode (not daemonized).', 105 - $daemon)."\n"); 102 + if ($argv) { 103 + $console->writeOut( 104 + pht( 105 + "Launching daemon \"%s\" in debug mode (not daemonized) ". 106 + "with arguments %s.\n", 107 + $daemon, 108 + csprintf('%LR', $argv))); 109 + } else { 110 + $console->writeOut( 111 + pht( 112 + "Launching daemon \"%s\" in debug mode (not daemonized).\n", 113 + $daemon)); 114 + } 106 115 } else { 107 - $console->writeOut( 108 - pht( 109 - 'Launching daemon "%s".', 110 - $daemon)."\n"); 116 + if ($argv) { 117 + $console->writeOut( 118 + pht( 119 + "Launching daemon \"%s\" with arguments %s.\n", 120 + $daemon, 121 + csprintf('%LR', $argv))); 122 + } else { 123 + $console->writeOut( 124 + pht( 125 + "Launching daemon \"%s\".\n", 126 + $daemon)); 127 + } 111 128 } 112 129 113 130 foreach ($argv as $key => $arg) {