@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add a "disabled" style
Summary: Fixes T3525. This feels way better, although it's still a little hard for me to pick out of lists with otherwise default-colored items.
Test Plan: {F49910} {F49911}
Reviewers: chad
Reviewed By: chad
CC: aran
Maniphest Tasks: T3525
Differential Revision: https://secure.phabricator.com/D6435
+93
-46
+45
-45
src/__celerity_resource_map__.php
+45
-45
src/__celerity_resource_map__.php
···
3334
3334
),
3335
3335
'phabricator-object-item-list-view-css' =>
3336
3336
array(
3337
-
'uri' => '/res/fa3c7eb1/rsrc/css/layout/phabricator-object-item-list-view.css',
3337
+
'uri' => '/res/a3e45d8a/rsrc/css/layout/phabricator-object-item-list-view.css',
3338
3338
'type' => 'css',
3339
3339
'requires' =>
3340
3340
array(
···
4149
4149
), array(
4150
4150
'packages' =>
4151
4151
array(
4152
-
'6e2d527c' =>
4152
+
'c01cebae' =>
4153
4153
array(
4154
4154
'name' => 'core.pkg.css',
4155
4155
'symbols' =>
···
4197
4197
40 => 'phabricator-property-list-view-css',
4198
4198
41 => 'phabricator-tag-view-css',
4199
4199
),
4200
-
'uri' => '/res/pkg/6e2d527c/core.pkg.css',
4200
+
'uri' => '/res/pkg/c01cebae/core.pkg.css',
4201
4201
'type' => 'css',
4202
4202
),
4203
4203
'75ccea43' =>
···
4391
4391
'reverse' =>
4392
4392
array(
4393
4393
'aphront-attached-file-view-css' => 'adc3c36d',
4394
-
'aphront-dialog-view-css' => '6e2d527c',
4395
-
'aphront-error-view-css' => '6e2d527c',
4396
-
'aphront-form-view-css' => '6e2d527c',
4397
-
'aphront-list-filter-view-css' => '6e2d527c',
4398
-
'aphront-pager-view-css' => '6e2d527c',
4399
-
'aphront-panel-view-css' => '6e2d527c',
4400
-
'aphront-table-view-css' => '6e2d527c',
4401
-
'aphront-tokenizer-control-css' => '6e2d527c',
4402
-
'aphront-tooltip-css' => '6e2d527c',
4403
-
'aphront-typeahead-control-css' => '6e2d527c',
4394
+
'aphront-dialog-view-css' => 'c01cebae',
4395
+
'aphront-error-view-css' => 'c01cebae',
4396
+
'aphront-form-view-css' => 'c01cebae',
4397
+
'aphront-list-filter-view-css' => 'c01cebae',
4398
+
'aphront-pager-view-css' => 'c01cebae',
4399
+
'aphront-panel-view-css' => 'c01cebae',
4400
+
'aphront-table-view-css' => 'c01cebae',
4401
+
'aphront-tokenizer-control-css' => 'c01cebae',
4402
+
'aphront-tooltip-css' => 'c01cebae',
4403
+
'aphront-typeahead-control-css' => 'c01cebae',
4404
4404
'differential-changeset-view-css' => 'dd27a69b',
4405
4405
'differential-core-view-css' => 'dd27a69b',
4406
4406
'differential-inline-comment-editor' => '504ca7d2',
···
4414
4414
'differential-table-of-contents-css' => 'dd27a69b',
4415
4415
'diffusion-commit-view-css' => 'c8ce2d88',
4416
4416
'diffusion-icons-css' => 'c8ce2d88',
4417
-
'global-drag-and-drop-css' => '6e2d527c',
4417
+
'global-drag-and-drop-css' => 'c01cebae',
4418
4418
'inline-comment-summary-css' => 'dd27a69b',
4419
4419
'javelin-aphlict' => '75ccea43',
4420
4420
'javelin-behavior' => 'a9f14d76',
···
4488
4488
'javelin-util' => 'a9f14d76',
4489
4489
'javelin-vector' => 'a9f14d76',
4490
4490
'javelin-workflow' => 'a9f14d76',
4491
-
'lightbox-attachment-css' => '6e2d527c',
4491
+
'lightbox-attachment-css' => 'c01cebae',
4492
4492
'maniphest-task-summary-css' => 'adc3c36d',
4493
4493
'maniphest-transaction-detail-css' => 'adc3c36d',
4494
-
'phabricator-action-list-view-css' => '6e2d527c',
4495
-
'phabricator-application-launch-view-css' => '6e2d527c',
4494
+
'phabricator-action-list-view-css' => 'c01cebae',
4495
+
'phabricator-application-launch-view-css' => 'c01cebae',
4496
4496
'phabricator-busy' => '75ccea43',
4497
4497
'phabricator-content-source-view-css' => 'dd27a69b',
4498
-
'phabricator-core-css' => '6e2d527c',
4499
-
'phabricator-crumbs-view-css' => '6e2d527c',
4498
+
'phabricator-core-css' => 'c01cebae',
4499
+
'phabricator-crumbs-view-css' => 'c01cebae',
4500
4500
'phabricator-drag-and-drop-file-upload' => '504ca7d2',
4501
4501
'phabricator-dropdown-menu' => '75ccea43',
4502
4502
'phabricator-file-upload' => '75ccea43',
4503
-
'phabricator-filetree-view-css' => '6e2d527c',
4504
-
'phabricator-flag-css' => '6e2d527c',
4505
-
'phabricator-form-view-css' => '6e2d527c',
4506
-
'phabricator-header-view-css' => '6e2d527c',
4503
+
'phabricator-filetree-view-css' => 'c01cebae',
4504
+
'phabricator-flag-css' => 'c01cebae',
4505
+
'phabricator-form-view-css' => 'c01cebae',
4506
+
'phabricator-header-view-css' => 'c01cebae',
4507
4507
'phabricator-hovercard' => '75ccea43',
4508
-
'phabricator-jump-nav' => '6e2d527c',
4508
+
'phabricator-jump-nav' => 'c01cebae',
4509
4509
'phabricator-keyboard-shortcut' => '75ccea43',
4510
4510
'phabricator-keyboard-shortcut-manager' => '75ccea43',
4511
-
'phabricator-main-menu-view' => '6e2d527c',
4511
+
'phabricator-main-menu-view' => 'c01cebae',
4512
4512
'phabricator-menu-item' => '75ccea43',
4513
-
'phabricator-nav-view-css' => '6e2d527c',
4513
+
'phabricator-nav-view-css' => 'c01cebae',
4514
4514
'phabricator-notification' => '75ccea43',
4515
-
'phabricator-notification-css' => '6e2d527c',
4516
-
'phabricator-notification-menu-css' => '6e2d527c',
4517
-
'phabricator-object-item-list-view-css' => '6e2d527c',
4515
+
'phabricator-notification-css' => 'c01cebae',
4516
+
'phabricator-notification-menu-css' => 'c01cebae',
4517
+
'phabricator-object-item-list-view-css' => 'c01cebae',
4518
4518
'phabricator-object-selector-css' => 'dd27a69b',
4519
4519
'phabricator-phtize' => '75ccea43',
4520
4520
'phabricator-prefab' => '75ccea43',
4521
4521
'phabricator-project-tag-css' => 'adc3c36d',
4522
-
'phabricator-property-list-view-css' => '6e2d527c',
4523
-
'phabricator-remarkup-css' => '6e2d527c',
4522
+
'phabricator-property-list-view-css' => 'c01cebae',
4523
+
'phabricator-remarkup-css' => 'c01cebae',
4524
4524
'phabricator-shaped-request' => '504ca7d2',
4525
-
'phabricator-side-menu-view-css' => '6e2d527c',
4526
-
'phabricator-standard-page-view' => '6e2d527c',
4527
-
'phabricator-tag-view-css' => '6e2d527c',
4525
+
'phabricator-side-menu-view-css' => 'c01cebae',
4526
+
'phabricator-standard-page-view' => 'c01cebae',
4527
+
'phabricator-tag-view-css' => 'c01cebae',
4528
4528
'phabricator-textareautils' => '75ccea43',
4529
4529
'phabricator-tooltip' => '75ccea43',
4530
-
'phabricator-transaction-view-css' => '6e2d527c',
4531
-
'phabricator-zindex-css' => '6e2d527c',
4532
-
'phui-button-css' => '6e2d527c',
4533
-
'phui-form-css' => '6e2d527c',
4534
-
'phui-icon-view-css' => '6e2d527c',
4535
-
'phui-spacing-css' => '6e2d527c',
4536
-
'sprite-apps-large-css' => '6e2d527c',
4537
-
'sprite-gradient-css' => '6e2d527c',
4538
-
'sprite-icons-css' => '6e2d527c',
4539
-
'sprite-menu-css' => '6e2d527c',
4540
-
'syntax-highlighting-css' => '6e2d527c',
4530
+
'phabricator-transaction-view-css' => 'c01cebae',
4531
+
'phabricator-zindex-css' => 'c01cebae',
4532
+
'phui-button-css' => 'c01cebae',
4533
+
'phui-form-css' => 'c01cebae',
4534
+
'phui-icon-view-css' => 'c01cebae',
4535
+
'phui-spacing-css' => 'c01cebae',
4536
+
'sprite-apps-large-css' => 'c01cebae',
4537
+
'sprite-gradient-css' => 'c01cebae',
4538
+
'sprite-icons-css' => 'c01cebae',
4539
+
'sprite-menu-css' => 'c01cebae',
4540
+
'syntax-highlighting-css' => 'c01cebae',
4541
4541
),
4542
4542
));
+1
src/applications/config/controller/PhabricatorConfigIssueListController.php
+1
src/applications/config/controller/PhabricatorConfigIssueListController.php
+1
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
+1
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
···
262
262
if ($named_query->getIsBuiltin()) {
263
263
if ($named_query->getIsDisabled()) {
264
264
$item->addIcon('delete-grey', pht('Disabled'));
265
+
$item->setDisabled(true);
265
266
} else {
266
267
$item->addIcon('lock-grey', pht('Builtin'));
267
268
}
268
-
$item->setBarColor('grey');
269
269
} else {
270
270
$item->addAction(
271
271
id(new PHUIListItemView())
+13
src/applications/uiexample/examples/PhabricatorObjectItemListExample.php
+13
src/applications/uiexample/examples/PhabricatorObjectItemListExample.php
···
172
172
->addAction(
173
173
id(new PHUIListItemView())
174
174
->setHref('#')
175
+
->setName(pht('Moo'))
175
176
->setIcon('edit')));
176
177
177
178
$list->addItem(
···
182
183
->addAction(
183
184
id(new PHUIListItemView())
184
185
->setHref('#')
186
+
->setName(pht('Quack'))
185
187
->setIcon('edit'))
186
188
->addAction(
187
189
id(new PHUIListItemView())
188
190
->setHref('#')
191
+
->setName(pht('Oink'))
189
192
->setIcon('delete')));
190
193
191
194
$out[] = array($head, $list);
···
243
246
244
247
$list->addItem(
245
248
id(new PhabricatorObjectItemView())
249
+
->setObjectName('X1')
246
250
->setHeader(pht('Normal'))
247
251
->setHref('#'));
248
252
249
253
$list->addItem(
250
254
id(new PhabricatorObjectItemView())
255
+
->setObjectName('X2')
251
256
->setHeader(pht('Highlighted'))
252
257
->setEffect('highlighted')
253
258
->setHref('#'));
254
259
255
260
$list->addItem(
256
261
id(new PhabricatorObjectItemView())
262
+
->setObjectName('X3')
257
263
->setHeader(pht('Selected'))
258
264
->setEffect('selected')
265
+
->setHref('#'));
266
+
267
+
$list->addItem(
268
+
id(new PhabricatorObjectItemView())
269
+
->setObjectName('X4')
270
+
->setHeader(pht('Disabled'))
271
+
->setDisabled(true)
259
272
->setHref('#'));
260
273
261
274
$out[] = array($head, $list);
+1
src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php
+1
src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php
+14
src/view/layout/PhabricatorObjectItemView.php
+14
src/view/layout/PhabricatorObjectItemView.php
···
17
17
private $grippable;
18
18
private $actions = array();
19
19
private $headIcons = array();
20
+
private $disabled;
21
+
22
+
public function setDisabled($disabled) {
23
+
$this->disabled = $disabled;
24
+
return $this;
25
+
}
26
+
27
+
public function getDisabled() {
28
+
return $this->disabled;
29
+
}
20
30
21
31
public function addHeadIcon($icon) {
22
32
$this->headIcons[] = $icon;
···
170
180
$n = count($this->actions);
171
181
$item_classes[] = 'phabricator-object-item-with-actions';
172
182
$item_classes[] = 'phabricator-object-item-with-'.$n.'-actions';
183
+
}
184
+
185
+
if ($this->disabled) {
186
+
$item_classes[] = 'phabricator-object-item-disabled';
173
187
}
174
188
175
189
switch ($this->effect) {
+18
webroot/rsrc/css/layout/phabricator-object-item-list-view.css
+18
webroot/rsrc/css/layout/phabricator-object-item-list-view.css
···
358
358
border-left-color: #333333;
359
359
}
360
360
361
+
/* - Disabled ------------------------------------------------------------------
362
+
363
+
Disabled/inactive objects.
364
+
365
+
*/
366
+
367
+
.phabricator-object-item-disabled {
368
+
border-left-color: #d7d7d7;
369
+
}
370
+
371
+
.phabricator-object-item-disabled .phabricator-object-item-frame {
372
+
border-color: #d7d7d7;
373
+
}
374
+
375
+
.phabricator-object-item-disabled .phabricator-object-item-objname {
376
+
color: #777777;
377
+
}
378
+
361
379
362
380
/* - Effects -------------------------------------------------------------------
363
381