recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make "Create Document" in Phriction use workflow

Summary:
My claims that this worked on D4183 were incorrect:

- Make it work.
- Then use it.
- Also make cancel URI not cancel to the same page.

Test Plan: Clicked "Create Document", got a workflow on-page dialog instead of a page transition.

Reviewers: codeblock

Reviewed By: codeblock

CC: aran

Differential Revision: https://secure.phabricator.com/D4403

epriestley b73622b8 368657a5

+8 -2
+1
src/applications/phriction/controller/PhrictionController.php
··· 53 53 id(new PhabricatorMenuItemView()) 54 54 ->setName(pht('Create Document')) 55 55 ->setHref('/phriction/new/') 56 + ->setWorkflow(true) 56 57 ->setIcon('create')); 57 58 58 59 return $crumbs;
+1 -1
src/applications/phriction/controller/PhrictionNewController.php
··· 30 30 pht('Create a new document at'))) 31 31 ->appendChild($view) 32 32 ->addSubmitButton(pht('Create')) 33 - ->addCancelButton($request->getRequestURI()); 33 + ->addCancelButton('/w/'); 34 34 35 35 return id(new AphrontDialogResponse())->setDialog($dialog); 36 36 }
+2 -1
src/view/layout/PhabricatorCrumbsView.php
··· 37 37 ), 38 38 ''); 39 39 } 40 - $actions[] = phutil_render_tag( 40 + $actions[] = javelin_render_tag( 41 41 'a', 42 42 array( 43 43 'href' => $action->getHref(), 44 44 'class' => 'phabricator-crumbs-action', 45 + 'sigil' => $action->getWorkflow() ? 'workflow' : null, 45 46 ), 46 47 $icon.phutil_escape_html($action->getName())); 47 48 }
+4
src/view/layout/PhabricatorMenuItemView.php
··· 90 90 return $this; 91 91 } 92 92 93 + public function getWorkflow() { 94 + return $this->workflow; 95 + } 96 + 93 97 public function setSortOrder($order) { 94 98 $this->sortOrder = $order; 95 99 return $this;