@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor document rendering fixes: dropdown for synchronous files, URI normalization for default renderers
Summary:
Depends on D19258. Ref T13105.
- When the default renderer is an Ajax renderer, don't replace the URI. For example, when viewing a Jupyter notebook, the URI should remain `/F123`, not instantly change to `/view/123/jupyter/`.
- Fix an issue where non-ajax renderers could fail to display the dropdown menu properly.
Test Plan:
- Viewed a Jupyter notebook, stayed on the same URI.
- Changed rendering, got different URIs.
- Viewed a JSON file and toggled renderers via dropdown.
Reviewers: mydeveloperday
Reviewed By: mydeveloperday
Maniphest Tasks: T13105
Differential Revision: https://secure.phabricator.com/D19259
+12
-9
+7
-7
resources/celerity/map.php
+7
-7
resources/celerity/map.php
···
392
392
'rsrc/js/application/diffusion/behavior-pull-lastmodified.js' => 'f01586dc',
393
393
'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => '1db13e70',
394
394
'rsrc/js/application/drydock/drydock-live-operation-status.js' => '901935ef',
395
-
'rsrc/js/application/files/behavior-document-engine.js' => 'd3f8623c',
395
+
'rsrc/js/application/files/behavior-document-engine.js' => '194cbe53',
396
396
'rsrc/js/application/files/behavior-icon-composer.js' => '8499b6ab',
397
397
'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888',
398
398
'rsrc/js/application/harbormaster/behavior-harbormaster-log.js' => '191b4909',
···
607
607
'javelin-behavior-diffusion-jump-to' => '73d09eef',
608
608
'javelin-behavior-diffusion-locate-file' => '6d3e1947',
609
609
'javelin-behavior-diffusion-pull-lastmodified' => 'f01586dc',
610
-
'javelin-behavior-document-engine' => 'd3f8623c',
610
+
'javelin-behavior-document-engine' => '194cbe53',
611
611
'javelin-behavior-doorkeeper-tag' => '1db13e70',
612
612
'javelin-behavior-drydock-live-operation-status' => '901935ef',
613
613
'javelin-behavior-durable-column' => '2ae077e1',
···
982
982
),
983
983
'191b4909' => array(
984
984
'javelin-behavior',
985
+
),
986
+
'194cbe53' => array(
987
+
'javelin-behavior',
988
+
'javelin-dom',
989
+
'javelin-stratcom',
985
990
),
986
991
'1ad0a787' => array(
987
992
'javelin-install',
···
2001
2006
),
2002
2007
'd254d646' => array(
2003
2008
'javelin-util',
2004
-
),
2005
-
'd3f8623c' => array(
2006
-
'javelin-behavior',
2007
-
'javelin-dom',
2008
-
'javelin-stratcom',
2009
2009
),
2010
2010
'd4505101' => array(
2011
2011
'javelin-stratcom',
+5
-2
webroot/rsrc/js/application/files/behavior-document-engine.js
+5
-2
webroot/rsrc/js/application/files/behavior-document-engine.js
···
73
73
var handler = JX.bind(null, onrender, data, data.sequence);
74
74
75
75
data.viewKey = spec.viewKey;
76
-
JX.History.replace(spec.viewURI);
77
76
78
77
new JX.Request(spec.engineURI, handler)
79
78
.send();
···
91
90
92
91
var load = JX.bind(null, onloading, data, spec);
93
92
data.loadTimer = setTimeout(load, 333);
93
+
94
+
// Replace the URI with the URI for the specific rendering the user
95
+
// has selected.
96
+
JX.History.replace(spec.viewURI);
94
97
}
95
98
}
96
99
···
128
131
statics.initialized = true;
129
132
}
130
133
131
-
if (config.renderControlID) {
134
+
if (config && config.renderControlID) {
132
135
var control = JX.$(config.renderControlID);
133
136
var data = JX.Stratcom.getData(control);
134
137