@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up Maniphest email "to"
Summary:
We currently try to send Maniphest email "To" the owner and actor, but for unassigned tasks there is no owner.
Just filter the PHIDs in the parent, since it's reasonable for subclasses to be liberal about construction here.
Test Plan: Commented on an unassigned task, got an email without a bogus "To".
Reviewers: btrahan, asherkin
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D7129
+2
-2
+2
-2
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+2
-2
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
1205
1205
PhabricatorLiskDAO $object,
1206
1206
array $xactions) {
1207
1207
1208
-
$email_to = array_unique($this->getMailTo($object));
1209
-
$email_cc = array_unique($this->getMailCC($object));
1208
+
$email_to = array_filter(array_unique($this->getMailTo($object)));
1209
+
$email_cc = array_filter(array_unique($this->getMailCC($object)));
1210
1210
1211
1211
$phids = array_merge($email_to, $email_cc);
1212
1212
$handles = id(new PhabricatorHandleQuery())