@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "HarbormasterBuildTransaction::TYPE_CREATE"
Summary: Ref T13072. No callers currently generate these transactions, and they probably never have. Remove them.
Test Plan: Grepped for "HarbormasterBuildTransaction::TYPE_CREATE" and "self::TYPE_CREATE" in the class, found no hits.
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Maniphest Tasks: T13072
Differential Revision: https://secure.phabricator.com/D21688
-16
-7
src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php
-7
src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php
···
14
14
public function getTransactionTypes() {
15
15
$types = parent::getTransactionTypes();
16
16
17
-
$types[] = HarbormasterBuildTransaction::TYPE_CREATE;
18
17
$types[] = HarbormasterBuildTransaction::TYPE_COMMAND;
19
18
20
19
return $types;
···
25
24
PhabricatorApplicationTransaction $xaction) {
26
25
27
26
switch ($xaction->getTransactionType()) {
28
-
case HarbormasterBuildTransaction::TYPE_CREATE:
29
27
case HarbormasterBuildTransaction::TYPE_COMMAND:
30
28
return null;
31
29
}
···
38
36
PhabricatorApplicationTransaction $xaction) {
39
37
40
38
switch ($xaction->getTransactionType()) {
41
-
case HarbormasterBuildTransaction::TYPE_CREATE:
42
-
return true;
43
39
case HarbormasterBuildTransaction::TYPE_COMMAND:
44
40
return $xaction->getNewValue();
45
41
}
···
52
48
PhabricatorApplicationTransaction $xaction) {
53
49
54
50
switch ($xaction->getTransactionType()) {
55
-
case HarbormasterBuildTransaction::TYPE_CREATE:
56
-
return;
57
51
case HarbormasterBuildTransaction::TYPE_COMMAND:
58
52
return $this->executeBuildCommand($object, $xaction);
59
53
}
···
98
92
PhabricatorApplicationTransaction $xaction) {
99
93
100
94
switch ($xaction->getTransactionType()) {
101
-
case HarbormasterBuildTransaction::TYPE_CREATE:
102
95
case HarbormasterBuildTransaction::TYPE_COMMAND:
103
96
return;
104
97
}
-9
src/applications/harbormaster/storage/HarbormasterBuildTransaction.php
-9
src/applications/harbormaster/storage/HarbormasterBuildTransaction.php
···
3
3
final class HarbormasterBuildTransaction
4
4
extends PhabricatorApplicationTransaction {
5
5
6
-
const TYPE_CREATE = 'harbormaster:build:create';
7
6
const TYPE_COMMAND = 'harbormaster:build:command';
8
7
9
8
public function getApplicationName() {
···
21
20
$new = $this->getNewValue();
22
21
23
22
switch ($this->getTransactionType()) {
24
-
case self::TYPE_CREATE:
25
-
return pht(
26
-
'%s created this build.',
27
-
$this->renderHandleLink($author_phid));
28
23
case self::TYPE_COMMAND:
29
24
switch ($new) {
30
25
case HarbormasterBuildCommand::COMMAND_RESTART:
···
55
50
$new = $this->getNewValue();
56
51
57
52
switch ($this->getTransactionType()) {
58
-
case self::TYPE_CREATE:
59
-
return 'fa-plus';
60
53
case self::TYPE_COMMAND:
61
54
switch ($new) {
62
55
case HarbormasterBuildCommand::COMMAND_RESTART:
···
80
73
$new = $this->getNewValue();
81
74
82
75
switch ($this->getTransactionType()) {
83
-
case self::TYPE_CREATE:
84
-
return 'green';
85
76
case self::TYPE_COMMAND:
86
77
switch ($new) {
87
78
case HarbormasterBuildCommand::COMMAND_PAUSE: