@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with error handling when no mailers are available
Summary:
Ref T13164. See PHI785. See D19546. I think I didn't test the updated error messaging here entirely properly, since I have some tasks in queue which error out here ("Missing argument 1 to newMailers(...)").
This is an error condition already, but we want to get through this call so we can raise a tailored message.
Test Plan: Tasks which errored out here now succeed. This condition is only reachable if you misconfigure things in the first place.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13164
Differential Revision: https://secure.phabricator.com/D19572
+1
-1
+1
-1
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
+1
-1
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
···
621
621
622
622
public function sendWithMailers(array $mailers) {
623
623
if (!$mailers) {
624
-
$any_mailers = self::newMailers();
624
+
$any_mailers = self::newMailers(array());
625
625
626
626
// NOTE: We can end up here with some custom list of "$mailers", like
627
627
// from a unit test. In that case, this message could be misleading. We