@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Passphrase cancel URI
Summary: The "Cancel" button on the "Edit Credential" interface doesn't go back to the "View Credential" interface for existing credentials.
Test Plan: Clicked "Cancel" on both "create" and "edit" workflows.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D8568
+4
-2
+4
-2
src/applications/passphrase/controller/PassphraseCredentialEditController.php
+4
-2
src/applications/passphrase/controller/PassphraseCredentialEditController.php
···
272
272
$title = pht('Create Credential');
273
273
$header = pht('Create New Credential');
274
274
$crumbs->addTextCrumb(pht('Create'));
275
+
$cancel_uri = $this->getApplicationURI();
275
276
} else {
276
277
$title = pht('Edit Credential');
277
278
$header = pht('Edit Credential %s', 'K'.$credential->getID());
···
279
280
'K'.$credential->getID(),
280
281
'/K'.$credential->getID());
281
282
$crumbs->addTextCrumb(pht('Edit'));
283
+
$cancel_uri = '/K'.$credential->getID();
282
284
}
283
285
284
286
if ($request->isAjax()) {
···
293
295
->appendChild($errors)
294
296
->appendChild($form->buildLayoutView())
295
297
->addSubmitButton(pht('Create Credential'))
296
-
->addCancelButton($this->getApplicationURI());
298
+
->addCancelButton($cancel_uri);
297
299
298
300
return id(new AphrontDialogResponse())->setDialog($dialog);
299
301
}
···
301
303
$form->appendChild(
302
304
id(new AphrontFormSubmitControl())
303
305
->setValue(pht('Save'))
304
-
->addCancelButton($this->getApplicationURI()));
306
+
->addCancelButton($cancel_uri));
305
307
306
308
$box = id(new PHUIObjectBoxView())
307
309
->setHeaderText($header)