@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Index revision comments
Summary: Only inlines were indexed (contrary to what comment claims).
Test Plan: Index one revision, check database.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Koolvin
Differential Revision: https://secure.phabricator.com/D2359
+8
-4
+7
-4
src/applications/search/index/indexer/differential/PhabricatorSearchDifferentialIndexer.php
+7
-4
src/applications/search/index/indexer/differential/PhabricatorSearchDifferentialIndexer.php
···
52
52
time());
53
53
}
54
54
55
-
$comments = id(new DifferentialInlineComment())->loadAllWhere(
56
-
'revisionID = %d AND commentID is not null',
55
+
$comments = id(new DifferentialComment())->loadAllWhere(
56
+
'revisionID = %d',
57
+
$rev->getID());
58
+
59
+
$inlines = id(new DifferentialInlineComment())->loadAllWhere(
60
+
'revisionID = %d AND commentID IS NOT NULL',
57
61
$rev->getID());
58
62
59
63
$touches = array();
60
64
61
-
foreach ($comments as $comment) {
65
+
foreach (array_merge($comments, $inlines) as $comment) {
62
66
if (strlen($comment->getContent())) {
63
-
// TODO: we should also index inline comments.
64
67
$doc->addField(
65
68
PhabricatorSearchField::FIELD_COMMENT,
66
69
$comment->getContent());
+1
src/applications/search/index/indexer/differential/__init__.php
+1
src/applications/search/index/indexer/differential/__init__.php
···
8
8
9
9
phutil_require_module('arcanist', 'differential/constants/revisionstatus');
10
10
11
+
phutil_require_module('phabricator', 'applications/differential/storage/comment');
11
12
phutil_require_module('phabricator', 'applications/differential/storage/inlinecomment');
12
13
phutil_require_module('phabricator', 'applications/phid/constants');
13
14
phutil_require_module('phabricator', 'applications/phid/handle/data');