@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Dashboards for handleRequest
Summary: Updates Dashboards app
Test Plan: Click on Manage Dashboard, page load a.ok
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D13836
+4
-10
+4
-10
src/applications/dashboard/controller/PhabricatorDashboardManageController.php
+4
-10
src/applications/dashboard/controller/PhabricatorDashboardManageController.php
···
3
3
final class PhabricatorDashboardManageController
4
4
extends PhabricatorDashboardController {
5
5
6
-
private $id;
7
-
8
-
public function willProcessRequest(array $data) {
9
-
$this->id = $data['id'];
10
-
}
6
+
public function handleRequest(AphrontRequest $request) {
7
+
$viewer = $request->getViewer();
8
+
$id = $request->getURIData('id');
11
9
12
-
public function processRequest() {
13
-
$request = $this->getRequest();
14
-
$viewer = $request->getUser();
15
-
$id = $this->id;
16
10
$dashboard_uri = $this->getApplicationURI('view/'.$id.'/');
17
11
18
12
// TODO: This UI should drop a lot of capabilities if the user can't
···
21
15
22
16
$dashboard = id(new PhabricatorDashboardQuery())
23
17
->setViewer($viewer)
24
-
->withIDs(array($this->id))
18
+
->withIDs(array($id))
25
19
->needPanels(true)
26
20
->executeOne();
27
21
if (!$dashboard) {