recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Changed \$callsign to \$argv[1] on commit_hook.php since is undefined causing an error when trying to report an error.

Summary:
Phabricator was going to give me an error message via commit_hook.php, unfortunately said error wasn't being set since
\$callsign was undefined. So, just changed \$callsign to \$argv[1] and now I get the appropriate commit.

Test Plan:
1. Add commit_hook.php to an SVN pre-commit.
2. Set the SVN to be hosted off of Phabricator.
3. Attempt to commit to commit to SVN repository.
Expected: Error message saying that the repository isn't hosted on Phabricator
Results: Error message saying undefined function.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7920

authored by

John Mullanaphy and committed by
epriestley b960c811 3c5756ad

+2 -2
+2 -2
scripts/repository/commit_hook.php
··· 17 17 ->executeOne(); 18 18 19 19 if (!$repository) { 20 - throw new Exception(pht('No such repository "%s"!', $callsign)); 20 + throw new Exception(pht('No such repository "%s"!', $argv[1])); 21 21 } 22 22 23 23 if (!$repository->isHosted()) { 24 24 // This should be redundant, but double check just in case. 25 - throw new Exception(pht('Repository "%s" is not hosted!', $callsign)); 25 + throw new Exception(pht('Repository "%s" is not hosted!', $argv[1])); 26 26 } 27 27 28 28 $engine->setRepository($repository);