recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Deprecate "bin/phd ... --gently" and update documentation

Summary:
Ref T13321. Previously, the behavior was:

- `bin/phd stop --gently`: Stop all daemons with PID files that belong to the current instance.
- `bin/phd stop`: Stop all daemons with PID files that belong to the current instance. Complain if there are more processes.
- `bin/phd stop --force`: Stop all processes that look like daemons, ignoring instances.

The new behavior is:

- `bin/phd stop`: Stop all processes that look like daemons and belong to the current instance.
- `bin/phd stop --force`: Stop all processes that look like daemons, period.

Test Plan: Grep / documentation only.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13321

Differential Revision: https://secure.phabricator.com/D20602

epriestley b99c240a d98bf8ef

+14 -24
+10 -9
src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php
··· 6 6 protected function didConstruct() { 7 7 $this 8 8 ->setName('restart') 9 - ->setSynopsis(pht('Stop, then start the standard daemon loadout.')) 9 + ->setSynopsis( 10 + pht( 11 + 'Stop daemon processes on this host, then start the standard '. 12 + 'daemon loadout.')) 10 13 ->setArguments( 11 14 array( 12 15 array( ··· 18 21 'default' => 15, 19 22 ), 20 23 array( 21 - 'name' => 'gently', 24 + 'name' => 'force', 22 25 'help' => pht( 23 - 'Ignore running processes that look like daemons but do not '. 24 - 'have corresponding PID files.'), 26 + 'Stop all daemon processes on this host, even if they belong '. 27 + 'to another Phabricator instance.'), 25 28 ), 26 29 array( 27 - 'name' => 'force', 28 - 'help' => pht( 29 - 'Also stop running processes that look like daemons but do '. 30 - 'not have corresponding PID files.'), 30 + 'name' => 'gently', 31 + 'help' => pht('Deprecated. Has no effect.'), 31 32 ), 32 33 $this->getAutoscaleReserveArgument(), 33 34 )); ··· 38 39 array( 39 40 'graceful' => $args->getArg('graceful'), 40 41 'force' => $args->getArg('force'), 41 - 'gently' => $args->getArg('gently'), 42 42 )); 43 + 43 44 if ($err) { 44 45 return $err; 45 46 }
+4 -15
src/applications/daemon/management/PhabricatorDaemonManagementStopWorkflow.php
··· 6 6 protected function didConstruct() { 7 7 $this 8 8 ->setName('stop') 9 - ->setSynopsis( 10 - pht( 11 - 'Stop all running daemons, or specific daemons identified by PIDs. '. 12 - 'Use **%s** to find PIDs.', 13 - 'phd status')) 9 + ->setSynopsis(pht('Stop daemon processes on this host.')) 14 10 ->setArguments( 15 11 array( 16 12 array( ··· 24 20 array( 25 21 'name' => 'force', 26 22 'help' => pht( 27 - 'Also stop running processes that look like daemons but do '. 28 - 'not have corresponding PID files.'), 23 + 'Stop all daemon processes on this host, even if they belong '. 24 + 'to another Phabricator instance.'), 29 25 ), 30 26 array( 31 27 'name' => 'gently', 32 - 'help' => pht( 33 - 'Ignore running processes that look like daemons but do not '. 34 - 'have corresponding PID files.'), 35 - ), 36 - array( 37 - 'name' => 'pids', 38 - 'wildcard' => true, 28 + 'help' => pht('Deprecated. Has no effect.'), 39 29 ), 40 30 )); 41 31 } ··· 45 35 array( 46 36 'graceful' => $args->getArg('graceful'), 47 37 'force' => $args->getArg('force'), 48 - 'gently' => $args->getArg('gently'), 49 38 )); 50 39 } 51 40