recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Correct a parameter order swap in "diffusion.historyquery" for Mercurial

Summary: Ref T13666. See T13666#256253. The order of these parameters is incorrect (introduced in D18817, which was trying to turn the revset "A or B" into "B or A"), but when "commit" is the single head of "branch" (which is common), the revset is functionally equivalent.

Test Plan:
An easy reproduction case is to make a "diffusion.historyquery" call manually against a Mercurial repository, with a valid "branch" name and some non-head "commit".

- Before patch, queried "head^" (by commit hash, not by symbol) of "default" and got "head" too (wrong).
- Applied patch to `secure001.phacility.net` (my local `hg` web environment is iffy right now).
- Re-ran the same query, saw "head^" as the first result rather than "head" (all hashes rather than symbols, as above), which is desired.

Reviewers: cspeckmim

Reviewed By: cspeckmim

Maniphest Tasks: T13666

Differential Revision: https://secure.phabricator.com/D21722

epriestley b9ba0418 3b2868e1

+2 -2
+2 -2
src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
··· 145 145 } else { 146 146 $revset_arg = hgsprintf( 147 147 'reverse(ancestors(%s)) and branch(%s)', 148 - $drequest->getBranch(), 149 - $commit_hash); 148 + $commit_hash, 149 + $drequest->getBranch()); 150 150 } 151 151 152 152 $hg_analyzer = PhutilBinaryAnalyzer::getForBinary('hg');