@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Modernize Maniphest
Summary: Updates (some) of Maniphest for modern methods. Didn't convert Reports (probably need a setNavigation call added).
Test Plan: View List, edit task, new task, view reports.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D14597
+32
-31
+4
-8
src/applications/maniphest/controller/ManiphestController.php
+4
-8
src/applications/maniphest/controller/ManiphestController.php
···
6
6
return $this->buildSideNavView(true)->getMenu();
7
7
}
8
8
9
-
public function buildSideNavView($for_app = false) {
10
-
$user = $this->getRequest()->getUser();
9
+
public function buildSideNavView() {
10
+
$viewer = $this->getViewer();
11
11
12
12
$nav = new AphrontSideNavFilterView();
13
13
$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
14
14
15
-
if ($for_app) {
16
-
$nav->addFilter('task/create/', pht('Create Task'));
17
-
}
18
-
19
15
id(new ManiphestTaskSearchEngine())
20
-
->setViewer($user)
16
+
->setViewer($viewer)
21
17
->addNavigationItems($nav->getMenu());
22
18
23
-
if ($user->isLoggedIn()) {
19
+
if ($viewer->isLoggedIn()) {
24
20
// For now, don't give logged-out users access to reports.
25
21
$nav->addLabel(pht('Reports'));
26
22
$nav->addFilter('report', pht('Reports'));
+17
-13
src/applications/maniphest/controller/ManiphestTaskDetailController.php
+17
-13
src/applications/maniphest/controller/ManiphestTaskDetailController.php
···
349
349
$object_box->addPropertyList($description);
350
350
}
351
351
352
-
return $this->buildApplicationPage(
353
-
array(
354
-
$crumbs,
355
-
$info_view,
356
-
$object_box,
357
-
$timeline,
358
-
$comment_box,
359
-
$preview_panel,
360
-
),
361
-
array(
362
-
'title' => 'T'.$task->getID().' '.$task->getTitle(),
363
-
'pageObjects' => array($task->getPHID()),
364
-
));
352
+
$title = 'T'.$task->getID().' '.$task->getTitle();
353
+
354
+
return $this->newPage()
355
+
->setTitle($title)
356
+
->setCrumbs($crumbs)
357
+
->setPageObjectPHIDs(
358
+
array(
359
+
$task->getPHID(),
360
+
))
361
+
->appendChild(
362
+
array(
363
+
$info_view,
364
+
$object_box,
365
+
$timeline,
366
+
$comment_box,
367
+
$preview_panel,
368
+
));
365
369
}
366
370
367
371
private function buildHeaderView(ManiphestTask $task) {
+11
-10
src/applications/maniphest/controller/ManiphestTaskEditController.php
+11
-10
src/applications/maniphest/controller/ManiphestTaskEditController.php
···
741
741
742
742
$crumbs->addTextCrumb($header_name);
743
743
744
-
return $this->buildApplicationPage(
745
-
array(
746
-
$crumbs,
747
-
$form_box,
748
-
$preview,
749
-
),
750
-
array(
751
-
'title' => $header_name,
752
-
'pageObjects' => $page_objects,
753
-
));
744
+
$title = $header_name;
745
+
746
+
return $this->newPage()
747
+
->setTitle($title)
748
+
->setCrumbs($crumbs)
749
+
->setPageObjectPHIDs($page_objects)
750
+
->appendChild(
751
+
array(
752
+
$form_box,
753
+
$preview,
754
+
));
754
755
}
755
756
756
757
}