recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Prevent Differential changeset HTML anchors from colliding with comment anchors

Summary:
Fixes T12970. This is easier than I expected, and appears to occur in only one place.

This prevents a change from ever generating with an anchor like `#12345678`, which is ambiguous because it may be a comment anchor.

Test Plan: Viewed a revision, saw new `change-xxxyyyzzz` anchors, clicked one, got jumped to the right place.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12970

Differential Revision: https://secure.phabricator.com/D18465

epriestley ba1925b1 bc0963d5

+1 -1
+1 -1
src/applications/differential/storage/DifferentialChangeset.php
··· 170 170 } 171 171 172 172 public function getAnchorName() { 173 - return substr(md5($this->getFilename()), 0, 8); 173 + return 'change-'.PhabricatorHash::digestForIndex($this->getFilename()); 174 174 } 175 175 176 176 public function getAbsoluteRepositoryPath(