@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Settings for handleRequest
Summary: Run through the Settings controllers
Test Plan: Test various settings pages, save some settings.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D13775
+9
-16
+1
-2
src/applications/settings/controller/PhabricatorSettingsAdjustController.php
+1
-2
src/applications/settings/controller/PhabricatorSettingsAdjustController.php
···
3
3
final class PhabricatorSettingsAdjustController
4
4
extends PhabricatorController {
5
5
6
-
public function processRequest() {
7
-
$request = $this->getRequest();
6
+
public function handleRequest(AphrontRequest $request) {
8
7
$user = $request->getUser();
9
8
10
9
$prefs = $user->loadPreferences();
+8
-14
src/applications/settings/controller/PhabricatorSettingsMainController.php
+8
-14
src/applications/settings/controller/PhabricatorSettingsMainController.php
···
3
3
final class PhabricatorSettingsMainController
4
4
extends PhabricatorController {
5
5
6
-
private $id;
7
-
private $key;
8
6
private $user;
9
7
10
8
private function getUser() {
···
12
10
}
13
11
14
12
private function isSelf() {
15
-
$viewer_phid = $this->getRequest()->getUser()->getPHID();
13
+
$viewer_phid = $this->getViewer()->getPHID();
16
14
$user_phid = $this->getUser()->getPHID();
17
15
return ($viewer_phid == $user_phid);
18
16
}
19
17
20
-
public function willProcessRequest(array $data) {
21
-
$this->id = idx($data, 'id');
22
-
$this->key = idx($data, 'key');
23
-
}
24
-
25
-
public function processRequest() {
26
-
$request = $this->getRequest();
27
-
$viewer = $request->getUser();
18
+
public function handleRequest(AphrontRequest $request) {
19
+
$viewer = $this->getViewer();
20
+
$id = $request->getURIData('id');
21
+
$key = $request->getURIData('key');
28
22
29
-
if ($this->id) {
23
+
if ($id) {
30
24
$user = id(new PhabricatorPeopleQuery())
31
25
->setViewer($viewer)
32
-
->withIDs(array($this->id))
26
+
->withIDs(array($id))
33
27
->requireCapabilities(
34
28
array(
35
29
PhabricatorPolicyCapability::CAN_VIEW,
···
49
43
$panels = $this->buildPanels();
50
44
$nav = $this->renderSideNav($panels);
51
45
52
-
$key = $nav->selectFilter($this->key, head($panels)->getPanelKey());
46
+
$key = $nav->selectFilter($key, head($panels)->getPanelKey());
53
47
54
48
$panel = $panels[$key];
55
49
$panel->setUser($this->getUser());