recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make "bin/config set --database ..." resurrect deleted values

Summary:
Fixes T12409. Config entries may be marked as "deleted", and `bin/config set --database` doesn't un-delete them, so the edit doesn't do anything.

The "most correct" fix here is to swap to transactions so we run the same code, but just fix this narrowly for now since it's one line of code.

Test Plan:
- Set `maniphest.default-priority` to `123`.
- Deleted `maniphest.default-priority` from the web UI by deleting all the text in the box.
- Before patch: `bin/config set --database maniphest.default-priority 789` had no effect.
- After patch: `bin/config set --database maniphest.default-priority 789` worked.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12409

Differential Revision: https://secure.phabricator.com/D17506

epriestley ba2ee3a6 de4e8728

+4
+4
src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php
··· 158 158 $config_type = 'database'; 159 159 $config_entry = PhabricatorConfigEntry::loadConfigEntry($key); 160 160 $config_entry->setValue($value); 161 + 162 + // If the entry has been deleted, resurrect it. 163 + $config_entry->setIsDeleted(0); 164 + 161 165 $config_entry->save(); 162 166 } else { 163 167 $config_type = 'local';