@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8 and Diviner Technical Documentation

Summary:
This also fixes the field Personal Settings > Display Preferences > Monospaced Font, when empty.

Close T15621

Test Plan: Generate diviner stuff, navigate to the "Technical Documentation" section (In php 8.1+)

Reviewers: O1 Blessed Committers, mturdus, valerio.bozzolan

Reviewed By: O1 Blessed Committers, mturdus, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15621

Differential Revision: https://we.phorge.it/D25412

+2 -2
+1 -1
src/applications/diviner/storage/DivinerLiveSymbol.php
··· 172 172 public function getTitle() { 173 173 $title = parent::getTitle(); 174 174 175 - if (!strlen($title)) { 175 + if (!phutil_nonempty_string($title)) { 176 176 $title = $this->getName(); 177 177 } 178 178
+1 -1
src/applications/settings/setting/PhabricatorMonospacedFontSetting.php
··· 25 25 } 26 26 27 27 public function validateTransactionValue($value) { 28 - if (!strlen($value)) { 28 + if (!phutil_nonempty_string($value)) { 29 29 return; 30 30 } 31 31