@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make "Facts" publicly viewable
Summary: Ref T4830. Also deletes some very obsolete code.
Test Plan: Looked at Facts as logged out user.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T4830
Differential Revision: https://secure.phabricator.com/D9177
+22
-17
+4
src/applications/fact/application/PhabricatorApplicationFact.php
+4
src/applications/fact/application/PhabricatorApplicationFact.php
+8
-2
src/applications/fact/controller/PhabricatorFactChartController.php
+8
-2
src/applications/fact/controller/PhabricatorFactChartController.php
···
80
80
$panel->setHeader('Count of '.$spec->getName());
81
81
$panel->appendChild($chart);
82
82
83
-
return $this->buildStandardPageResponse(
84
-
$panel,
83
+
$crumbs = $this->buildApplicationCrumbs();
84
+
$crumbs->addTextCrumb(pht('Chart'));
85
+
86
+
return $this->buildApplicationPage(
87
+
array(
88
+
$crumbs,
89
+
$panel,
90
+
),
85
91
array(
86
92
'title' => 'Chart',
87
93
));
-13
src/applications/fact/controller/PhabricatorFactController.php
-13
src/applications/fact/controller/PhabricatorFactController.php
···
2
2
3
3
abstract class PhabricatorFactController extends PhabricatorController {
4
4
5
-
public function buildStandardPageResponse($view, array $data) {
6
-
$page = $this->buildStandardPageView();
7
-
8
-
$page->setBaseURI('/fact/');
9
-
$page->setTitle(idx($data, 'title'));
10
-
11
-
$page->setGlyph("\xCE\xA3");
12
-
$page->appendChild($view);
13
-
14
-
$response = new AphrontWebpageResponse();
15
-
return $response->setContent($page->render());
16
-
}
17
-
18
5
}
+10
-2
src/applications/fact/controller/PhabricatorFactHomeController.php
+10
-2
src/applications/fact/controller/PhabricatorFactHomeController.php
···
2
2
3
3
final class PhabricatorFactHomeController extends PhabricatorFactController {
4
4
5
+
public function shouldAllowPublic() {
6
+
return true;
7
+
}
8
+
5
9
public function processRequest() {
6
10
$request = $this->getRequest();
7
11
$user = $request->getUser();
···
53
57
54
58
$chart_form = $this->buildChartForm();
55
59
56
-
return $this->buildStandardPageResponse(
60
+
$crumbs = $this->buildApplicationCrumbs();
61
+
$crumbs->addTextCrumb(pht('Home'));
62
+
63
+
return $this->buildApplicationPage(
57
64
array(
65
+
$crumbs,
58
66
$chart_form,
59
67
$panel,
60
68
),
61
69
array(
62
-
'title' => 'Facts!',
70
+
'title' => 'Facts',
63
71
));
64
72
}
65
73