@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't add "To/Cc" to HTML mail bodies if there's no HTML mail body
Summary: Ref T6576. This avoids generating almost-empty HTML mail bodies for mail which incorrectly has no HTML body.
Test Plan: Generated some mail locally; the specific hook case is a pain for me to hit right now. Will push and dig in if that doesn't fix it.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T6576
Differential Revision: https://secure.phabricator.com/D10863
+4
-2
+4
-2
src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
+4
-2
src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
···
210
210
$body .= $this->getRecipientsSummary($to_handles, $cc_handles);
211
211
212
212
$html_body = $mail_template->getHTMLBody();
213
-
$html_body .= hsprintf('%s',
214
-
$this->getRecipientsSummaryHTML($to_handles, $cc_handles));
213
+
if (strlen($html_body)) {
214
+
$html_body .= hsprintf('%s',
215
+
$this->getRecipientsSummaryHTML($to_handles, $cc_handles));
216
+
}
215
217
216
218
foreach ($recipients as $phid => $recipient) {
217
219