@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add `rulePHID` to HeraldEffect
Summary: Ref T4195. Herald rules gained PHIDs only recently, propagate them to HeraldEffect to make some of the hook stuff eaiser.
Test Plan: iiam
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T4195
Differential Revision: https://secure.phabricator.com/D7781
+17
-6
+16
-6
src/applications/herald/engine/HeraldEffect.php
+16
-6
src/applications/herald/engine/HeraldEffect.php
···
2
2
3
3
final class HeraldEffect {
4
4
5
-
protected $objectPHID;
6
-
protected $action;
7
-
protected $target;
5
+
private $objectPHID;
6
+
private $action;
7
+
private $target;
8
8
9
-
protected $ruleID;
10
-
protected $effector;
9
+
private $ruleID;
10
+
private $rulePHID;
11
+
private $effector;
11
12
12
-
protected $reason;
13
+
private $reason;
13
14
14
15
public function setObjectPHID($object_phid) {
15
16
$this->objectPHID = $object_phid;
···
45
46
46
47
public function getRuleID() {
47
48
return $this->ruleID;
49
+
}
50
+
51
+
public function setRulePHID($rule_phid) {
52
+
$this->rulePHID = $rule_phid;
53
+
return $this;
54
+
}
55
+
56
+
public function getRulePHID() {
57
+
return $this->rulePHID;
48
58
}
49
59
50
60
public function setEffector($effector) {