@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Disable full screen mode for inline comments
Summary:
Full screen is a little foobar so disabling it for inline comments
Fixes T5272
Test Plan:
View inline comment after change, make sure full screen option
has gone.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin
Maniphest Tasks: T5272
Differential Revision: https://secure.phabricator.com/D9579
authored by
Gareth Evans
and committed by
epriestley
baa998fa
5aae1ee0
+19
-9
+2
-1
src/infrastructure/diff/PhabricatorInlineCommentController.php
+2
-1
src/infrastructure/diff/PhabricatorInlineCommentController.php
+17
-8
src/view/form/control/PhabricatorRemarkupControl.php
+17
-8
src/view/form/control/PhabricatorRemarkupControl.php
···
3
3
final class PhabricatorRemarkupControl extends AphrontFormTextAreaControl {
4
4
private $disableMacro = false;
5
5
6
+
private $disableFullScreen = false;
7
+
6
8
public function setDisableMacros($disable) {
7
9
$this->disableMacro = $disable;
10
+
return $this;
11
+
}
12
+
13
+
public function setDisableFullScreen($disable) {
14
+
$this->disableFullScreen = $disable;
8
15
return $this;
9
16
}
10
17
···
90
97
'href' => PhabricatorEnv::getDoclink('Remarkup Reference'),
91
98
);
92
99
93
-
$actions[] = array(
94
-
'spacer' => true,
95
-
'align' => 'right',
96
-
);
100
+
if (!$this->disableFullScreen) {
101
+
$actions[] = array(
102
+
'spacer' => true,
103
+
'align' => 'right',
104
+
);
97
105
98
-
$actions['fa-arrows-alt'] = array(
99
-
'tip' => pht('Fullscreen Mode'),
100
-
'align' => 'right',
101
-
);
106
+
$actions['fa-arrows-alt'] = array(
107
+
'tip' => pht('Fullscreen Mode'),
108
+
'align' => 'right',
109
+
);
110
+
}
102
111
103
112
$buttons = array();
104
113
foreach ($actions as $action => $spec) {