recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Respect repository identities when selecting author vs auditor actions

Summary:
Depends on D20580. Fixes T13311. When we choose which actions to show a user, we can either show them "auditor" actions (like "raise concern") or "author" actions (like "request verification").

Currently, we don't show "author" actions if you're the author of the commit via an identity mapping, but we should. Use identity mappings where they exist.

(Because I've implemented `getEffectiveAuthorPHID()` in a way that requires `$data` be attached, it's possible this will make something throw a "DataNotAttached" exception, but: probably it won't?; and that's easy to fix if it happens.)

Test Plan:
See D20580. As `@alice`, viewed the commit in the UI.

- Before: got auditor actions presented to me.
- After: got author actions.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13311

Differential Revision: https://secure.phabricator.com/D20581

epriestley bab35f28 4450c908

+1 -1
+1 -1
src/applications/diffusion/xaction/DiffusionCommitActionTransaction.php
··· 63 63 return false; 64 64 } 65 65 66 - return ($viewer->getPHID() === $commit->getAuthorPHID()); 66 + return ($viewer->getPHID() === $commit->getEffectiveAuthorPHID()); 67 67 } 68 68 69 69 public function newEditField(