@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "ManiphestTransactionEditorPro"
Summary: Drop the "Pro" bit.
Test Plan: Created/edited tasks, moved tasks around, generally made a mess. Nothing burned down.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D7352
+262
-280
+1
-3
src/__phutil_library_map__.php
+1
-3
src/__phutil_library_map__.php
···
749
749
'ManiphestTransaction' => 'applications/maniphest/storage/ManiphestTransaction.php',
750
750
'ManiphestTransactionComment' => 'applications/maniphest/storage/ManiphestTransactionComment.php',
751
751
'ManiphestTransactionEditor' => 'applications/maniphest/editor/ManiphestTransactionEditor.php',
752
-
'ManiphestTransactionEditorPro' => 'applications/maniphest/editor/ManiphestTransactionEditorPro.php',
753
752
'ManiphestTransactionPreviewController' => 'applications/maniphest/controller/ManiphestTransactionPreviewController.php',
754
753
'ManiphestTransactionQuery' => 'applications/maniphest/query/ManiphestTransactionQuery.php',
755
754
'ManiphestTransactionSaveController' => 'applications/maniphest/controller/ManiphestTransactionSaveController.php',
···
2895
2894
'ManiphestTaskSubscriber' => 'ManiphestDAO',
2896
2895
'ManiphestTransaction' => 'PhabricatorApplicationTransaction',
2897
2896
'ManiphestTransactionComment' => 'PhabricatorApplicationTransactionComment',
2898
-
'ManiphestTransactionEditor' => 'PhabricatorEditor',
2899
-
'ManiphestTransactionEditorPro' => 'PhabricatorApplicationTransactionEditor',
2897
+
'ManiphestTransactionEditor' => 'PhabricatorApplicationTransactionEditor',
2900
2898
'ManiphestTransactionPreviewController' => 'ManiphestController',
2901
2899
'ManiphestTransactionQuery' => 'PhabricatorApplicationTransactionQuery',
2902
2900
'ManiphestTransactionSaveController' => 'ManiphestController',
+1
-1
src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php
+1
-1
src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php
···
199
199
PhabricatorContentSource::SOURCE_CONDUIT,
200
200
array());
201
201
202
-
$editor = id(new ManiphestTransactionEditorPro())
202
+
$editor = id(new ManiphestTransactionEditor())
203
203
->setActor($request->getUser())
204
204
->setContentSource($content_source)
205
205
->setContinueOnNoEffect(true);
+1
-1
src/applications/maniphest/controller/ManiphestBatchEditController.php
+1
-1
src/applications/maniphest/controller/ManiphestBatchEditController.php
+1
-1
src/applications/maniphest/controller/ManiphestSubpriorityController.php
+1
-1
src/applications/maniphest/controller/ManiphestSubpriorityController.php
···
53
53
->setTransactionType(ManiphestTransaction::TYPE_PRIORITY)
54
54
->setNewValue($after_pri);
55
55
56
-
$editor = id(new ManiphestTransactionEditorPro())
56
+
$editor = id(new ManiphestTransactionEditor())
57
57
->setActor($user)
58
58
->setContinueOnMissingFields(true)
59
59
->setContinueOnNoEffect(true)
+1
-1
src/applications/maniphest/controller/ManiphestSubscribeController.php
+1
-1
src/applications/maniphest/controller/ManiphestSubscribeController.php
···
39
39
->setTransactionType(ManiphestTransaction::TYPE_CCS)
40
40
->setNewValue($ccs);
41
41
42
-
$editor = id(new ManiphestTransactionEditorPro())
42
+
$editor = id(new ManiphestTransactionEditor())
43
43
->setActor($user)
44
44
->setContentSourceFromRequest($request)
45
45
->setContinueOnNoEffect(true)
+1
-1
src/applications/maniphest/controller/ManiphestTaskEditController.php
+1
-1
src/applications/maniphest/controller/ManiphestTaskEditController.php
···
237
237
$task = $event->getValue('task');
238
238
$transactions = $event->getValue('transactions');
239
239
240
-
$editor = id(new ManiphestTransactionEditorPro())
240
+
$editor = id(new ManiphestTransactionEditor())
241
241
->setActor($user)
242
242
->setContentSourceFromRequest($request)
243
243
->setContinueOnNoEffect(true)
+1
-1
src/applications/maniphest/controller/ManiphestTransactionSaveController.php
+1
-1
src/applications/maniphest/controller/ManiphestTransactionSaveController.php
···
222
222
$task = $event->getValue('task');
223
223
$transactions = $event->getValue('transactions');
224
224
225
-
$editor = id(new ManiphestTransactionEditorPro())
225
+
$editor = id(new ManiphestTransactionEditor())
226
226
->setActor($user)
227
227
->setContentSourceFromRequest($request)
228
228
->setContinueOnMissingFields(true)
+245
-9
src/applications/maniphest/editor/ManiphestTransactionEditor.php
+245
-9
src/applications/maniphest/editor/ManiphestTransactionEditor.php
···
1
1
<?php
2
2
3
-
/**
4
-
* @group maniphest
5
-
*/
6
-
final class ManiphestTransactionEditor extends PhabricatorEditor {
3
+
final class ManiphestTransactionEditor
4
+
extends PhabricatorApplicationTransactionEditor {
5
+
6
+
public function getTransactionTypes() {
7
+
$types = parent::getTransactionTypes();
8
+
9
+
$types[] = PhabricatorTransactions::TYPE_COMMENT;
10
+
$types[] = ManiphestTransaction::TYPE_PRIORITY;
11
+
$types[] = ManiphestTransaction::TYPE_STATUS;
12
+
$types[] = ManiphestTransaction::TYPE_TITLE;
13
+
$types[] = ManiphestTransaction::TYPE_DESCRIPTION;
14
+
$types[] = ManiphestTransaction::TYPE_OWNER;
15
+
$types[] = ManiphestTransaction::TYPE_CCS;
16
+
$types[] = ManiphestTransaction::TYPE_PROJECTS;
17
+
$types[] = ManiphestTransaction::TYPE_ATTACH;
18
+
$types[] = ManiphestTransaction::TYPE_EDGE;
19
+
$types[] = PhabricatorTransactions::TYPE_VIEW_POLICY;
20
+
$types[] = PhabricatorTransactions::TYPE_EDIT_POLICY;
21
+
22
+
return $types;
23
+
}
24
+
25
+
protected function getCustomTransactionOldValue(
26
+
PhabricatorLiskDAO $object,
27
+
PhabricatorApplicationTransaction $xaction) {
28
+
29
+
switch ($xaction->getTransactionType()) {
30
+
case ManiphestTransaction::TYPE_PRIORITY:
31
+
if ($this->getIsNewObject()) {
32
+
return null;
33
+
}
34
+
return (int)$object->getPriority();
35
+
case ManiphestTransaction::TYPE_STATUS:
36
+
if ($this->getIsNewObject()) {
37
+
return null;
38
+
}
39
+
return (int)$object->getStatus();
40
+
case ManiphestTransaction::TYPE_TITLE:
41
+
if ($this->getIsNewObject()) {
42
+
return null;
43
+
}
44
+
return $object->getTitle();
45
+
case ManiphestTransaction::TYPE_DESCRIPTION:
46
+
if ($this->getIsNewObject()) {
47
+
return null;
48
+
}
49
+
return $object->getDescription();
50
+
case ManiphestTransaction::TYPE_OWNER:
51
+
return nonempty($object->getOwnerPHID(), null);
52
+
case ManiphestTransaction::TYPE_CCS:
53
+
return array_values(array_unique($object->getCCPHIDs()));
54
+
case ManiphestTransaction::TYPE_PROJECTS:
55
+
return array_values(array_unique($object->getProjectPHIDs()));
56
+
case ManiphestTransaction::TYPE_ATTACH:
57
+
return $object->getAttached();
58
+
case ManiphestTransaction::TYPE_EDGE:
59
+
// These are pre-populated.
60
+
return $xaction->getOldValue();
61
+
}
62
+
63
+
}
64
+
65
+
protected function getCustomTransactionNewValue(
66
+
PhabricatorLiskDAO $object,
67
+
PhabricatorApplicationTransaction $xaction) {
68
+
69
+
switch ($xaction->getTransactionType()) {
70
+
case ManiphestTransaction::TYPE_PRIORITY:
71
+
case ManiphestTransaction::TYPE_STATUS:
72
+
return (int)$xaction->getNewValue();
73
+
case ManiphestTransaction::TYPE_CCS:
74
+
case ManiphestTransaction::TYPE_PROJECTS:
75
+
return array_values(array_unique($xaction->getNewValue()));
76
+
case ManiphestTransaction::TYPE_OWNER:
77
+
return nonempty($xaction->getNewValue(), null);
78
+
case ManiphestTransaction::TYPE_TITLE:
79
+
case ManiphestTransaction::TYPE_DESCRIPTION:
80
+
case ManiphestTransaction::TYPE_ATTACH:
81
+
case ManiphestTransaction::TYPE_EDGE:
82
+
return $xaction->getNewValue();
83
+
}
84
+
85
+
}
86
+
87
+
protected function transactionHasEffect(
88
+
PhabricatorLiskDAO $object,
89
+
PhabricatorApplicationTransaction $xaction) {
90
+
91
+
$old = $xaction->getOldValue();
92
+
$new = $xaction->getNewValue();
93
+
94
+
switch ($xaction->getTransactionType()) {
95
+
case ManiphestTransaction::TYPE_PROJECTS:
96
+
case ManiphestTransaction::TYPE_CCS:
97
+
sort($old);
98
+
sort($new);
99
+
return ($old !== $new);
100
+
}
7
101
8
-
public function buildReplyHandler(ManiphestTask $task) {
9
-
$handler_object = PhabricatorEnv::newObjectFromConfig(
10
-
'metamta.maniphest.reply-handler');
11
-
$handler_object->setMailReceiver($task);
102
+
return parent::transactionHasEffect($object, $xaction);
103
+
}
104
+
105
+
106
+
protected function applyCustomInternalTransaction(
107
+
PhabricatorLiskDAO $object,
108
+
PhabricatorApplicationTransaction $xaction) {
12
109
13
-
return $handler_object;
110
+
switch ($xaction->getTransactionType()) {
111
+
case ManiphestTransaction::TYPE_PRIORITY:
112
+
return $object->setPriority($xaction->getNewValue());
113
+
case ManiphestTransaction::TYPE_STATUS:
114
+
return $object->setStatus($xaction->getNewValue());
115
+
case ManiphestTransaction::TYPE_TITLE:
116
+
return $object->setTitle($xaction->getNewValue());
117
+
case ManiphestTransaction::TYPE_DESCRIPTION:
118
+
return $object->setDescription($xaction->getNewValue());
119
+
case ManiphestTransaction::TYPE_OWNER:
120
+
return $object->setOwnerPHID($xaction->getNewValue());
121
+
case ManiphestTransaction::TYPE_CCS:
122
+
return $object->setCCPHIDs($xaction->getNewValue());
123
+
case ManiphestTransaction::TYPE_PROJECTS:
124
+
return $object->setProjectPHIDs($xaction->getNewValue());
125
+
case ManiphestTransaction::TYPE_ATTACH:
126
+
return $object->setAttached($xaction->getNewValue());
127
+
case ManiphestTransaction::TYPE_EDGE:
128
+
// These are a weird, funky mess and are already being applied by the
129
+
// time we reach this.
130
+
return;
131
+
}
132
+
133
+
}
134
+
135
+
protected function applyCustomExternalTransaction(
136
+
PhabricatorLiskDAO $object,
137
+
PhabricatorApplicationTransaction $xaction) {
138
+
}
139
+
140
+
protected function shouldSendMail(
141
+
PhabricatorLiskDAO $object,
142
+
array $xactions) {
143
+
return true;
144
+
}
145
+
146
+
protected function getMailSubjectPrefix() {
147
+
return PhabricatorEnv::getEnvConfig('metamta.maniphest.subject-prefix');
148
+
}
149
+
150
+
protected function getMailThreadID(PhabricatorLiskDAO $object) {
151
+
return 'maniphest-task-'.$object->getPHID();
152
+
}
153
+
154
+
protected function getMailTo(PhabricatorLiskDAO $object) {
155
+
return array(
156
+
$object->getOwnerPHID(),
157
+
$this->requireActor()->getPHID(),
158
+
);
159
+
}
160
+
161
+
protected function getMailCC(PhabricatorLiskDAO $object) {
162
+
return $object->getCCPHIDs();
163
+
}
164
+
165
+
protected function buildReplyHandler(PhabricatorLiskDAO $object) {
166
+
return id(new ManiphestReplyHandler())
167
+
->setMailReceiver($object);
168
+
}
169
+
170
+
protected function buildMailTemplate(PhabricatorLiskDAO $object) {
171
+
$id = $object->getID();
172
+
$title = $object->getTitle();
173
+
174
+
return id(new PhabricatorMetaMTAMail())
175
+
->setSubject("T{$id}: {$title}")
176
+
->addHeader('Thread-Topic', "T{$id}: ".$object->getOriginalTitle());
177
+
}
178
+
179
+
protected function buildMailBody(
180
+
PhabricatorLiskDAO $object,
181
+
array $xactions) {
182
+
183
+
$body = parent::buildMailBody($object, $xactions);
184
+
185
+
if ($this->getIsNewObject()) {
186
+
$body->addTextSection(
187
+
pht('TASK DESCRIPTION'),
188
+
$object->getDescription());
189
+
}
190
+
191
+
$body->addTextSection(
192
+
pht('TASK DETAIL'),
193
+
PhabricatorEnv::getProductionURI('/T'.$object->getID()));
194
+
195
+
return $body;
196
+
}
197
+
198
+
protected function supportsFeed() {
199
+
return true;
200
+
}
201
+
202
+
protected function supportsSearch() {
203
+
return true;
204
+
}
205
+
206
+
protected function supportsHerald() {
207
+
return true;
208
+
}
209
+
210
+
protected function buildHeraldAdapter(
211
+
PhabricatorLiskDAO $object,
212
+
array $xactions) {
213
+
214
+
return id(new HeraldManiphestTaskAdapter())
215
+
->setTask($object);
216
+
}
217
+
218
+
protected function didApplyHeraldRules(
219
+
PhabricatorLiskDAO $object,
220
+
HeraldAdapter $adapter,
221
+
HeraldTranscript $transcript) {
222
+
223
+
$save_again = false;
224
+
$cc_phids = $adapter->getCcPHIDs();
225
+
if ($cc_phids) {
226
+
$existing_cc = $object->getCCPHIDs();
227
+
$new_cc = array_unique(array_merge($cc_phids, $existing_cc));
228
+
$object->setCCPHIDs($new_cc);
229
+
$save_again = true;
230
+
}
231
+
232
+
$assign_phid = $adapter->getAssignPHID();
233
+
if ($assign_phid) {
234
+
$object->setOwnerPHID($assign_phid);
235
+
$save_again = true;
236
+
}
237
+
238
+
$project_phids = $adapter->getProjectPHIDs();
239
+
if ($project_phids) {
240
+
$existing_projects = $object->getProjectPHIDs();
241
+
$new_projects = array_unique(
242
+
array_merge($project_phids, $existing_projects));
243
+
$object->setProjectPHIDs($new_projects);
244
+
$save_again = true;
245
+
}
246
+
247
+
if ($save_again) {
248
+
$object->save();
249
+
}
14
250
}
15
251
16
252
public static function getNextSubpriority($pri, $sub) {
-252
src/applications/maniphest/editor/ManiphestTransactionEditorPro.php
-252
src/applications/maniphest/editor/ManiphestTransactionEditorPro.php
···
1
-
<?php
2
-
3
-
final class ManiphestTransactionEditorPro
4
-
extends PhabricatorApplicationTransactionEditor {
5
-
6
-
public function getTransactionTypes() {
7
-
$types = parent::getTransactionTypes();
8
-
9
-
$types[] = PhabricatorTransactions::TYPE_COMMENT;
10
-
$types[] = ManiphestTransaction::TYPE_PRIORITY;
11
-
$types[] = ManiphestTransaction::TYPE_STATUS;
12
-
$types[] = ManiphestTransaction::TYPE_TITLE;
13
-
$types[] = ManiphestTransaction::TYPE_DESCRIPTION;
14
-
$types[] = ManiphestTransaction::TYPE_OWNER;
15
-
$types[] = ManiphestTransaction::TYPE_CCS;
16
-
$types[] = ManiphestTransaction::TYPE_PROJECTS;
17
-
$types[] = ManiphestTransaction::TYPE_ATTACH;
18
-
$types[] = ManiphestTransaction::TYPE_EDGE;
19
-
$types[] = PhabricatorTransactions::TYPE_VIEW_POLICY;
20
-
$types[] = PhabricatorTransactions::TYPE_EDIT_POLICY;
21
-
22
-
return $types;
23
-
}
24
-
25
-
protected function getCustomTransactionOldValue(
26
-
PhabricatorLiskDAO $object,
27
-
PhabricatorApplicationTransaction $xaction) {
28
-
29
-
switch ($xaction->getTransactionType()) {
30
-
case ManiphestTransaction::TYPE_PRIORITY:
31
-
if ($this->getIsNewObject()) {
32
-
return null;
33
-
}
34
-
return (int)$object->getPriority();
35
-
case ManiphestTransaction::TYPE_STATUS:
36
-
if ($this->getIsNewObject()) {
37
-
return null;
38
-
}
39
-
return (int)$object->getStatus();
40
-
case ManiphestTransaction::TYPE_TITLE:
41
-
if ($this->getIsNewObject()) {
42
-
return null;
43
-
}
44
-
return $object->getTitle();
45
-
case ManiphestTransaction::TYPE_DESCRIPTION:
46
-
if ($this->getIsNewObject()) {
47
-
return null;
48
-
}
49
-
return $object->getDescription();
50
-
case ManiphestTransaction::TYPE_OWNER:
51
-
return nonempty($object->getOwnerPHID(), null);
52
-
case ManiphestTransaction::TYPE_CCS:
53
-
return array_values(array_unique($object->getCCPHIDs()));
54
-
case ManiphestTransaction::TYPE_PROJECTS:
55
-
return array_values(array_unique($object->getProjectPHIDs()));
56
-
case ManiphestTransaction::TYPE_ATTACH:
57
-
return $object->getAttached();
58
-
case ManiphestTransaction::TYPE_EDGE:
59
-
// These are pre-populated.
60
-
return $xaction->getOldValue();
61
-
}
62
-
63
-
}
64
-
65
-
protected function getCustomTransactionNewValue(
66
-
PhabricatorLiskDAO $object,
67
-
PhabricatorApplicationTransaction $xaction) {
68
-
69
-
switch ($xaction->getTransactionType()) {
70
-
case ManiphestTransaction::TYPE_PRIORITY:
71
-
case ManiphestTransaction::TYPE_STATUS:
72
-
return (int)$xaction->getNewValue();
73
-
case ManiphestTransaction::TYPE_CCS:
74
-
case ManiphestTransaction::TYPE_PROJECTS:
75
-
return array_values(array_unique($xaction->getNewValue()));
76
-
case ManiphestTransaction::TYPE_OWNER:
77
-
return nonempty($xaction->getNewValue(), null);
78
-
case ManiphestTransaction::TYPE_TITLE:
79
-
case ManiphestTransaction::TYPE_DESCRIPTION:
80
-
case ManiphestTransaction::TYPE_ATTACH:
81
-
case ManiphestTransaction::TYPE_EDGE:
82
-
return $xaction->getNewValue();
83
-
}
84
-
85
-
}
86
-
87
-
protected function transactionHasEffect(
88
-
PhabricatorLiskDAO $object,
89
-
PhabricatorApplicationTransaction $xaction) {
90
-
91
-
$old = $xaction->getOldValue();
92
-
$new = $xaction->getNewValue();
93
-
94
-
switch ($xaction->getTransactionType()) {
95
-
case ManiphestTransaction::TYPE_PROJECTS:
96
-
case ManiphestTransaction::TYPE_CCS:
97
-
sort($old);
98
-
sort($new);
99
-
return ($old !== $new);
100
-
}
101
-
102
-
return parent::transactionHasEffect($object, $xaction);
103
-
}
104
-
105
-
106
-
protected function applyCustomInternalTransaction(
107
-
PhabricatorLiskDAO $object,
108
-
PhabricatorApplicationTransaction $xaction) {
109
-
110
-
switch ($xaction->getTransactionType()) {
111
-
case ManiphestTransaction::TYPE_PRIORITY:
112
-
return $object->setPriority($xaction->getNewValue());
113
-
case ManiphestTransaction::TYPE_STATUS:
114
-
return $object->setStatus($xaction->getNewValue());
115
-
case ManiphestTransaction::TYPE_TITLE:
116
-
return $object->setTitle($xaction->getNewValue());
117
-
case ManiphestTransaction::TYPE_DESCRIPTION:
118
-
return $object->setDescription($xaction->getNewValue());
119
-
case ManiphestTransaction::TYPE_OWNER:
120
-
return $object->setOwnerPHID($xaction->getNewValue());
121
-
case ManiphestTransaction::TYPE_CCS:
122
-
return $object->setCCPHIDs($xaction->getNewValue());
123
-
case ManiphestTransaction::TYPE_PROJECTS:
124
-
return $object->setProjectPHIDs($xaction->getNewValue());
125
-
case ManiphestTransaction::TYPE_ATTACH:
126
-
return $object->setAttached($xaction->getNewValue());
127
-
case ManiphestTransaction::TYPE_EDGE:
128
-
// These are a weird, funky mess and are already being applied by the
129
-
// time we reach this.
130
-
return;
131
-
}
132
-
133
-
}
134
-
135
-
protected function applyCustomExternalTransaction(
136
-
PhabricatorLiskDAO $object,
137
-
PhabricatorApplicationTransaction $xaction) {
138
-
}
139
-
140
-
protected function shouldSendMail(
141
-
PhabricatorLiskDAO $object,
142
-
array $xactions) {
143
-
return true;
144
-
}
145
-
146
-
protected function getMailSubjectPrefix() {
147
-
return PhabricatorEnv::getEnvConfig('metamta.maniphest.subject-prefix');
148
-
}
149
-
150
-
protected function getMailThreadID(PhabricatorLiskDAO $object) {
151
-
return 'maniphest-task-'.$object->getPHID();
152
-
}
153
-
154
-
protected function getMailTo(PhabricatorLiskDAO $object) {
155
-
return array(
156
-
$object->getOwnerPHID(),
157
-
$this->requireActor()->getPHID(),
158
-
);
159
-
}
160
-
161
-
protected function getMailCC(PhabricatorLiskDAO $object) {
162
-
return $object->getCCPHIDs();
163
-
}
164
-
165
-
protected function buildReplyHandler(PhabricatorLiskDAO $object) {
166
-
return id(new ManiphestReplyHandler())
167
-
->setMailReceiver($object);
168
-
}
169
-
170
-
protected function buildMailTemplate(PhabricatorLiskDAO $object) {
171
-
$id = $object->getID();
172
-
$title = $object->getTitle();
173
-
174
-
return id(new PhabricatorMetaMTAMail())
175
-
->setSubject("T{$id}: {$title}")
176
-
->addHeader('Thread-Topic', "T{$id}: ".$object->getOriginalTitle());
177
-
}
178
-
179
-
protected function buildMailBody(
180
-
PhabricatorLiskDAO $object,
181
-
array $xactions) {
182
-
183
-
$body = parent::buildMailBody($object, $xactions);
184
-
185
-
if ($this->getIsNewObject()) {
186
-
$body->addTextSection(
187
-
pht('TASK DESCRIPTION'),
188
-
$object->getDescription());
189
-
}
190
-
191
-
$body->addTextSection(
192
-
pht('TASK DETAIL'),
193
-
PhabricatorEnv::getProductionURI('/T'.$object->getID()));
194
-
195
-
return $body;
196
-
}
197
-
198
-
protected function supportsFeed() {
199
-
return true;
200
-
}
201
-
202
-
protected function supportsSearch() {
203
-
return true;
204
-
}
205
-
206
-
protected function supportsHerald() {
207
-
return true;
208
-
}
209
-
210
-
protected function buildHeraldAdapter(
211
-
PhabricatorLiskDAO $object,
212
-
array $xactions) {
213
-
214
-
return id(new HeraldManiphestTaskAdapter())
215
-
->setTask($object);
216
-
}
217
-
218
-
protected function didApplyHeraldRules(
219
-
PhabricatorLiskDAO $object,
220
-
HeraldAdapter $adapter,
221
-
HeraldTranscript $transcript) {
222
-
223
-
$save_again = false;
224
-
$cc_phids = $adapter->getCcPHIDs();
225
-
if ($cc_phids) {
226
-
$existing_cc = $object->getCCPHIDs();
227
-
$new_cc = array_unique(array_merge($cc_phids, $existing_cc));
228
-
$object->setCCPHIDs($new_cc);
229
-
$save_again = true;
230
-
}
231
-
232
-
$assign_phid = $adapter->getAssignPHID();
233
-
if ($assign_phid) {
234
-
$object->setOwnerPHID($assign_phid);
235
-
$save_again = true;
236
-
}
237
-
238
-
$project_phids = $adapter->getProjectPHIDs();
239
-
if ($project_phids) {
240
-
$existing_projects = $object->getProjectPHIDs();
241
-
$new_projects = array_unique(
242
-
array_merge($project_phids, $existing_projects));
243
-
$object->setProjectPHIDs($new_projects);
244
-
$save_again = true;
245
-
}
246
-
247
-
if ($save_again) {
248
-
$object->save();
249
-
}
250
-
}
251
-
252
-
}
+1
-1
src/applications/maniphest/event/ManiphestEdgeEventListener.php
+1
-1
src/applications/maniphest/event/ManiphestEdgeEventListener.php
+1
-1
src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php
+1
-1
src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php
+3
-3
src/applications/maniphest/mail/ManiphestCreateMailReceiver.php
+3
-3
src/applications/maniphest/mail/ManiphestCreateMailReceiver.php
···
63
63
$task = ManiphestTask::initializeNewTask($sender);
64
64
$task->setOriginalEmailSource($mail->getHeader('From'));
65
65
66
-
$editor = new ManiphestTransactionEditor();
67
-
$editor->setActor($sender);
68
-
$handler = $editor->buildReplyHandler($task);
66
+
$handler = PhabricatorEnv::newObjectFromConfig(
67
+
'metamta.maniphest.reply-handler');
68
+
$handler->setMailReceiver($task);
69
69
70
70
$handler->setActor($sender);
71
71
$handler->setExcludeMailRecipientPHIDs(
+1
-1
src/applications/maniphest/mail/ManiphestReplyHandler.php
+1
-1
src/applications/maniphest/mail/ManiphestReplyHandler.php
···
165
165
$task = $event->getValue('task');
166
166
$xactions = $event->getValue('transactions');
167
167
168
-
$editor = id(new ManiphestTransactionEditorPro())
168
+
$editor = id(new ManiphestTransactionEditor())
169
169
->setActor($user)
170
170
->setParentMessageID($mail->getMessageID())
171
171
->setExcludeMailRecipientPHIDs($this->getExcludeMailRecipientPHIDs())
+3
-3
src/applications/maniphest/mail/ManiphestTaskMailReceiver.php
+3
-3
src/applications/maniphest/mail/ManiphestTaskMailReceiver.php
···
27
27
PhabricatorLiskDAO $object,
28
28
PhabricatorUser $sender) {
29
29
30
-
$editor = new ManiphestTransactionEditor();
31
-
$editor->setActor($sender);
32
-
$handler = $editor->buildReplyHandler($object);
30
+
$handler = PhabricatorEnv::newObjectFromConfig(
31
+
'metamta.maniphest.reply-handler');
32
+
$handler->setMailReceiver($object);
33
33
34
34
$handler->setActor($sender);
35
35
$handler->setExcludeMailRecipientPHIDs(
+1
-1
src/applications/search/controller/PhabricatorSearchAttachController.php
+1
-1
src/applications/search/controller/PhabricatorSearchAttachController.php