recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove unused revisionID and whitespace properties from diff TOC view

Summary: Ref T2183. These properties are not used and not useful.

Test Plan: Grepped for callsites and uses. Loaded revisions.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2183

Differential Revision: https://secure.phabricator.com/D13906

epriestley bb0d1334 74bf0d6e

-14
-2
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 359 359 } 360 360 $toc_view->setDiff($target); 361 361 $toc_view->setUser($user); 362 - $toc_view->setRevisionID($revision->getID()); 363 - $toc_view->setWhitespace($whitespace); 364 362 365 363 $comment_form = null; 366 364 if (!$viewer_is_anonymous) {
-12
src/applications/differential/view/DifferentialDiffTableOfContentsView.php
··· 8 8 private $repository; 9 9 private $diff; 10 10 private $renderURI = '/differential/changeset/'; 11 - private $revisionID; 12 - private $whitespace; 13 11 private $coverageMap; 14 12 15 13 public function setChangesets($changesets) { ··· 39 37 40 38 public function setCoverageMap(array $coverage_map) { 41 39 $this->coverageMap = $coverage_map; 42 - return $this; 43 - } 44 - 45 - public function setRevisionID($revision_id) { 46 - $this->revisionID = $revision_id; 47 - return $this; 48 - } 49 - 50 - public function setWhitespace($whitespace) { 51 - $this->whitespace = $whitespace; 52 40 return $this; 53 41 } 54 42