recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a possible fatal on the first push to a cluster repository

Summary:
Fixes T11020. I think this resolves things -- `$new_version` (set above) should be used, not `$new_log` directly.

Specifically, we would get into trouble if the initial push failed for some reason (working copy not initialized yet, commit hook rejected, etc).

Test Plan: Made a bad push to a new repository. Saw it freeze before the patch and succeed afterwards.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11020

Differential Revision: https://secure.phabricator.com/D15969

epriestley bb16a1b0 725d60eb

+1 -1
+1 -1
src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
··· 391 391 $repository_phid, 392 392 $device_phid, 393 393 $this->clusterWriteVersion, 394 - $new_log->getID(), 394 + $new_version, 395 395 $this->clusterWriteOwner); 396 396 $did_release = true; 397 397 break;