@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
In PHUIInfoView, only show list UI if more than 1 item
Summary: We often just setError as an array even if it's only one error. This just makes the UI a little cleaner in these cases.
Test Plan: Remove all reviewers from a diff, see status error without list styling.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D14308
+3
-1
+3
-1
src/view/form/PHUIInfoView.php
+3
-1
src/view/form/PHUIInfoView.php
···
50
50
require_celerity_resource('phui-info-view-css');
51
51
52
52
$errors = $this->errors;
53
-
if ($errors) {
53
+
if (count($errors) > 1) {
54
54
$list = array();
55
55
foreach ($errors as $error) {
56
56
$list[] = phutil_tag(
···
64
64
'class' => 'phui-info-view-list',
65
65
),
66
66
$list);
67
+
} else if (count($errors) == 1) {
68
+
$list = $this->errors[0];
67
69
} else {
68
70
$list = null;
69
71
}