@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix task graph fatal for graphs containing restricted tasks
Summary: Fixes T11392. If some tasks are restricted, we only have PHIDs for them, not objects. Just use the PHIDs instead.
Test Plan: {F1741335}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11392
Differential Revision: https://secure.phabricator.com/D16345
+6
-8
+6
-8
src/infrastructure/graph/ManiphestTaskGraph.php
+6
-8
src/infrastructure/graph/ManiphestTaskGraph.php
···
74
74
$link = $viewer->renderHandle($phid);
75
75
}
76
76
77
-
78
-
79
-
if ($this->isParentTask($object)) {
77
+
if ($this->isParentTask($phid)) {
80
78
$marker = 'fa-chevron-circle-up bluegrey';
81
79
$marker_tip = pht('Direct Parent');
82
-
} else if ($this->isChildTask($object)) {
80
+
} else if ($this->isChildTask($phid)) {
83
81
$marker = 'fa-chevron-circle-down bluegrey';
84
82
$marker_tip = pht('Direct Subtask');
85
83
} else {
···
128
126
));
129
127
}
130
128
131
-
private function isParentTask(ManiphestTask $task) {
129
+
private function isParentTask($task_phid) {
132
130
$map = $this->getSeedMap(ManiphestTaskDependedOnByTaskEdgeType::EDGECONST);
133
-
return isset($map[$task->getPHID()]);
131
+
return isset($map[$task_phid]);
134
132
}
135
133
136
-
private function isChildTask(ManiphestTask $task) {
134
+
private function isChildTask($task_phid) {
137
135
$map = $this->getSeedMap(ManiphestTaskDependsOnTaskEdgeType::EDGECONST);
138
-
return isset($map[$task->getPHID()]);
136
+
return isset($map[$task_phid]);
139
137
}
140
138
141
139
private function getSeedMap($type) {