@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove addExtraQuicksandConfig
Summary: Removes all calls to addExtraQuicksandConfig Ref T9690
Test Plan: grep for addExtraQuicksandConfig, view a Pholio Page with and without chatbar, edit a pholio mock, save mock.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T9690
Differential Revision: https://secure.phabricator.com/D14622
authored by
Chad Little
and committed by
chad
bbd1da4f
774d2db8
+4
-24
-19
src/applications/base/controller/PhabricatorController.php
-19
src/applications/base/controller/PhabricatorController.php
···
463
463
$page->setUser($viewer);
464
464
}
465
465
466
-
// TODO: Remove after removing callsites to addExtraQuicksandConfig().
467
-
$page->addQuicksandConfig($this->extraQuicksandConfig);
468
-
469
466
return $page;
470
467
}
471
468
···
531
528
532
529
533
530
/* -( Deprecated )--------------------------------------------------------- */
534
-
535
-
536
-
/**
537
-
* DEPRECATED.
538
-
*/
539
-
private $extraQuicksandConfig = array();
540
-
541
-
542
-
/**
543
-
* DEPRECATED. Use @{method:newPage} and call addQuicksandConfig().
544
-
*/
545
-
public function addExtraQuicksandConfig($config) {
546
-
// TODO: When this method is removed,
547
-
$this->extraQuicksandConfig += $config;
548
-
return $this;
549
-
}
550
531
551
532
552
533
/**
+2
-3
src/applications/pholio/controller/PholioMockEditController.php
+2
-3
src/applications/pholio/controller/PholioMockEditController.php
···
382
382
$form_box,
383
383
);
384
384
385
-
$this->addExtraQuicksandConfig(
386
-
array('mockEditConfig' => true));
387
-
388
385
return $this->newPage()
389
386
->setTitle($title)
390
387
->setCrumbs($crumbs)
388
+
->addQuicksandConfig(
389
+
array('mockEditConfig' => true))
391
390
->appendChild(
392
391
array(
393
392
$form_box,
+2
-2
src/applications/pholio/controller/PholioMockViewController.php
+2
-2
src/applications/pholio/controller/PholioMockViewController.php
···
78
78
->setUser($viewer)
79
79
->setMock($mock)
80
80
->setImageID($image_id);
81
-
$this->addExtraQuicksandConfig(
82
-
array('mockViewConfig' => $mock_view->getBehaviorConfig()));
83
81
84
82
$output = id(new PHUIObjectBoxView())
85
83
->setHeaderText(pht('Image'))
···
102
100
->setTitle('M'.$mock->getID().' '.$title)
103
101
->setCrumbs($crumbs)
104
102
->setPageObjectPHIDs(array($mock->getPHID()))
103
+
->addQuicksandConfig(
104
+
array('mockViewConfig' => $mock_view->getBehaviorConfig()))
105
105
->appendChild(
106
106
array(
107
107
$object_box,