@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a stray comma on File previews
Summary:
There's a comma to the lower-left of my profile picture here:
{F248962}
This is on a page like https://secure.phabricator.com/F248948
What's happening is that some `render()` method is returning a valid result like `array($stuff, null)`. This is getting passed to JS as an array, which is implicitly `join()`'ing it into a string, adding a comma.
Instead, make sure we render these to strings on the server side before shipping them to the client.
Test Plan: No more comma on file previews.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D10974
+6
+6
src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php
+6
src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php
···
67
67
$xactions = mpull($view->buildEvents(), 'render', 'getTransactionPHID');
68
68
}
69
69
70
+
// Force whatever the underlying views built to render into HTML for
71
+
// the Javascript.
72
+
foreach ($xactions as $key => $xaction) {
73
+
$xactions[$key] = hsprintf('%s', $xaction);
74
+
}
75
+
70
76
$content = array(
71
77
'xactions' => $xactions,
72
78
'spacer' => PHUITimelineView::renderSpacer(),