@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Replace `elseif` by `else if`
Summary:
Mostly written by me.
Omit external libraries.
Test Plan: http://phabricator.com/docs/phabricator/article/PHP_Coding_Standards.html
Reviewers: epriestley
Reviewed By: epriestley
CC: aran
Differential Revision: https://secure.phabricator.com/D2104
+9
-9
+2
-2
src/applications/differential/controller/revisionlist/DifferentialRevisionListController.php
+2
-2
src/applications/differential/controller/revisionlist/DifferentialRevisionListController.php
···
406
406
case 'status':
407
407
if ($params['status'] == 'open') {
408
408
$query->withStatus(DifferentialRevisionQuery::STATUS_OPEN);
409
-
} elseif ($params['status'] == 'committed') {
409
+
} else if ($params['status'] == 'committed') {
410
410
$query->withStatus(DifferentialRevisionQuery::STATUS_COMMITTED);
411
-
} elseif ($params['status'] == 'abandoned') {
411
+
} else if ($params['status'] == 'abandoned') {
412
412
$query->withStatus(DifferentialRevisionQuery::STATUS_ABANDONED);
413
413
}
414
414
break;
+2
-2
src/applications/differential/parser/changeset/DifferentialChangesetParser.php
+2
-2
src/applications/differential/parser/changeset/DifferentialChangesetParser.php
···
1355
1355
if ($this->old[$ii]['type'] == '\\') {
1356
1356
$o_text = $this->old[$ii]['text'];
1357
1357
$o_attr = ' class="comment"';
1358
-
} elseif (empty($this->new[$ii])) {
1358
+
} else if (empty($this->new[$ii])) {
1359
1359
$o_attr = ' class="old old-full"';
1360
1360
} else {
1361
1361
$o_attr = ' class="old"';
···
1389
1389
if ($this->new[$ii]['type'] == '\\') {
1390
1390
$n_text = $this->new[$ii]['text'];
1391
1391
$n_attr = ' class="comment"';
1392
-
} elseif (empty($this->old[$ii])) {
1392
+
} else if (empty($this->old[$ii])) {
1393
1393
$n_attr = ' class="new new-full"';
1394
1394
} else {
1395
1395
$n_attr = ' class="new"';
+1
-1
src/applications/differential/view/revisioncommentlist/DifferentialRevisionCommentListView.php
+1
-1
src/applications/differential/view/revisioncommentlist/DifferentialRevisionCommentListView.php
···
89
89
$view->setVersusDiffID($this->versusDiffID);
90
90
if ($comment->getAction() == DifferentialAction::ACTION_SUMMARIZE) {
91
91
$view->setAnchorName('summary');
92
92
-
} elseif ($comment->getAction() == DifferentialAction::ACTION_TESTPLAN) {
92
92
+
} else if ($comment->getAction() == DifferentialAction::ACTION_TESTPLAN) {
93
93
$view->setAnchorName('test-plan');
94
94
} else {
95
95
$view->setAnchorName('comment-'.$num);
+3
-3
src/applications/search/controller/search/PhabricatorSearchController.php
+3
-3
src/applications/search/controller/search/PhabricatorSearchController.php
···
239
239
->loadOneWhere('callsign = %s', $match[1]);
240
240
if ($match[2] == '') {
241
241
$jump = $repository;
242
-
} elseif ($repository) {
242
+
} else if ($repository) {
243
243
$jump = id(new PhabricatorRepositoryCommit())->loadOneWhere(
244
244
'repositoryID = %d AND commitIdentifier = %s',
245
245
$repository->getID(),
···
255
255
}
256
256
}
257
257
}
258
-
} elseif (preg_match('/^d(\d+)$/i', $query_str, $match)) {
258
+
} else if (preg_match('/^d(\d+)$/i', $query_str, $match)) {
259
259
$jump = id(new DifferentialRevision())->load($match[1]);
260
-
} elseif (preg_match('/^t(\d+)$/i', $query_str, $match)) {
260
+
} else if (preg_match('/^t(\d+)$/i', $query_str, $match)) {
261
261
$jump = id(new ManiphestTask())->load($match[1]);
262
262
}
263
263
if ($jump) {
+1
-1
src/infrastructure/setup/PhabricatorSetup.php
+1
-1
src/infrastructure/setup/PhabricatorSetup.php
···
745
745
if (!$r->isSubclassOf($instanceof)) {
746
746
throw new Exception(
747
747
"Config setting '$key' must be an instance of '$instanceof'.");
748
-
} elseif (!$r->isInstantiable()) {
748
+
} else if (!$r->isInstantiable()) {
749
749
throw new Exception("Config setting '$key' must be instantiable.");
750
750
}
751
751
} catch (Exception $ex) {