@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix exception when viewing Owners packages owned by projects you are a member of
Summary: Fixes T3188. See that task for details.
Test Plan: Viewed packages with and without project membership; no more exception.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T3188
Differential Revision: https://secure.phabricator.com/D5918
+11
-7
+11
-7
src/applications/owners/controller/PhabricatorOwnersListController.php
+11
-7
src/applications/owners/controller/PhabricatorOwnersListController.php
···
115
115
->withStatus(PhabricatorProjectQuery::STATUS_ANY)
116
116
->execute();
117
117
$owner_phids = mpull($projects, 'getPHID');
118
-
$data = queryfx_all(
119
-
$package->establishConnection('r'),
120
-
'SELECT p.* FROM %T p JOIN %T o ON p.id = o.packageID
121
-
WHERE o.userPHID IN (%Ls) GROUP BY p.id',
122
-
$package->getTableName(),
123
-
$owner->getTableName(),
124
-
$owner_phids);
118
+
if ($owner_phids) {
119
+
$data = queryfx_all(
120
+
$package->establishConnection('r'),
121
+
'SELECT p.* FROM %T p JOIN %T o ON p.id = o.packageID
122
+
WHERE o.userPHID IN (%Ls) GROUP BY p.id',
123
+
$package->getTableName(),
124
+
$owner->getTableName(),
125
+
$owner_phids);
126
+
} else {
127
+
$data = array();
128
+
}
125
129
$packages = $package->loadAllFromArray($data);
126
130
127
131
$header = 'Owned Packages';