@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't apply patches or mark patches applied with `bin/storage upgrade --dryrun`
Summary: Fixes T12682.
Test Plan: Ran `bin/storage upgrade --dryrun` repeatedly with un-applied patches, saw it not apply them and not mark them applied.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12682
Differential Revision: https://secure.phabricator.com/D17837
+6
-2
+6
-2
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php
+6
-2
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php
···
1090
1090
}
1091
1091
1092
1092
$t_begin = microtime(true);
1093
-
$api->applyPatch($patch);
1093
+
if (!$is_dryrun) {
1094
+
$api->applyPatch($patch);
1095
+
}
1094
1096
$t_end = microtime(true);
1095
1097
1096
1098
$duration = ($t_end - $t_begin);
···
1100
1102
// If we're explicitly reapplying this patch, we don't need to
1101
1103
// mark it as applied.
1102
1104
if (!isset($state_map[$ref_key][$key])) {
1103
-
$api->markPatchApplied($key, ($t_end - $t_begin));
1105
+
if (!$is_dryrun) {
1106
+
$api->markPatchApplied($key, ($t_end - $t_begin));
1107
+
}
1104
1108
$applied_map[$ref_key][$key] = true;
1105
1109
}
1106
1110
}