@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - fix no conpherences fatal
Summary: Fixes T3087. I guess I didn't load up the actual Conpherence UI last time I was in here with my 'noconpherences' user. :/
Test Plan: noconpherences user loaded /conpherence/ with no error
Reviewers: epriestley, chad
Reviewed By: chad
CC: aran, Korvin
Maniphest Tasks: T3087
Differential Revision: https://secure.phabricator.com/D5815
+4
-3
+4
-3
src/applications/conpherence/controller/ConpherenceListController.php
+4
-3
src/applications/conpherence/controller/ConpherenceListController.php
···
228
228
private function loadConpherenceThreadData($participation) {
229
229
$user = $this->getRequest()->getUser();
230
230
$conpherence_phids = array_keys($participation);
231
+
$conpherences = array();
231
232
if ($conpherence_phids) {
232
233
$conpherences = id(new ConpherenceThreadQuery())
233
234
->setViewer($user)
234
235
->withPHIDs($conpherence_phids)
235
236
->needParticipantCache(true)
236
237
->execute();
237
-
}
238
238
239
-
// this will re-sort by participation data
240
-
$conpherences = array_select_keys($conpherences, $conpherence_phids);
239
+
// this will re-sort by participation data
240
+
$conpherences = array_select_keys($conpherences, $conpherence_phids);
241
+
}
241
242
242
243
return $conpherences;
243
244
}