@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Excel export of date columns
Summary:
In D4567, I made column formatting more strict, but possibly too strict. @anjali reports date columns showing internal Excel date formats ("42391.2292", etc).
@jack, if you have a chance, can you apply this and verify the behavior with @anjali? Repro steps should be:
- View any tasks in Maniphest.
- Click "Export to Excel".
- Open document in Excel.
- Date column should show dates, not integers around 42,000.
Otherwise I'll test this locally, I just need to rebuild some dependencies first which is a bit involved.
Test Plan: None yet.
Reviewers: jack, btrahan
Reviewed By: btrahan
CC: anjali, aran
Differential Revision: https://secure.phabricator.com/D5467
+4
-3
+4
-3
src/applications/maniphest/controller/ManiphestExportController.php
+4
-3
src/applications/maniphest/controller/ManiphestExportController.php
···
181
181
foreach ($rows as $row => $cols) {
182
182
foreach ($cols as $col => $spec) {
183
183
$cell_name = $this->col($col).($row + 1);
184
-
$sheet
185
-
->setCellValue($cell_name, $spec, $return_cell = true)
186
-
->setDataType(PHPExcel_Cell_DataType::TYPE_STRING);
184
+
$cell = $sheet
185
+
->setCellValue($cell_name, $spec, $return_cell = true);
187
186
188
187
if ($row == 0) {
189
188
$sheet->getStyle($cell_name)->applyFromArray($header_format);
···
195
194
->getStyle($cell_name)
196
195
->getNumberFormat()
197
196
->setFormatCode($code);
197
+
} else {
198
+
$cell->setDataType(PHPExcel_Cell_DataType::TYPE_STRING);
198
199
}
199
200
}
200
201
}