@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor search ui updates
Summary: Wanted to clean this up a little to make Deedy's diff hopefully easier. Removes some unneeded CSS, and Deedy's should remove more with object list.
Test Plan: Search for people, documents, tasks, etc. Test mobile and desktop layouts
Reviewers: epriestley, DeedyDas
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5880
+21
-15
+1
-1
src/__celerity_resource_map__.php
+1
-1
src/__celerity_resource_map__.php
···
3306
3306
),
3307
3307
'phabricator-search-results-css' =>
3308
3308
array(
3309
-
'uri' => '/res/f8a86e27/rsrc/css/application/search/search-results.css',
3309
+
'uri' => '/res/9b749d7d/rsrc/css/application/search/search-results.css',
3310
3310
'type' => 'css',
3311
3311
'requires' =>
3312
3312
array(
+14
-4
src/applications/search/controller/PhabricatorSearchController.php
+14
-4
src/applications/search/controller/PhabricatorSearchController.php
···
143
143
$search_form
144
144
->setUser($user)
145
145
->setAction('/search/')
146
+
->setNoShading(true)
146
147
->appendChild(
147
148
phutil_tag(
148
149
'input',
···
198
199
id(new AphrontFormSubmitControl())
199
200
->setValue('Search'));
200
201
201
-
$search_panel = new AphrontPanelView();
202
-
$search_panel->setHeader('Search Phabricator');
202
+
$search_panel = new AphrontListFilterView();
203
203
$search_panel->appendChild($search_form);
204
204
205
205
require_celerity_resource('phabricator-search-results-css');
···
241
241
->setObject(idx($objects, $phid));
242
242
$results[] = $view->render();
243
243
}
244
+
244
245
$results = hsprintf(
245
246
'<div class="phabricator-search-result-list">'.
246
247
'%s'.
···
254
255
'<p class="phabricator-search-no-results">No search results.</p>'.
255
256
'</div>');
256
257
}
258
+
$results = id(new PHUIBoxView())
259
+
->addMargin(PHUI::MARGIN_LARGE)
260
+
->addPadding(PHUI::PADDING_LARGE)
261
+
->setShadow(true)
262
+
->appendChild($results)
263
+
->addClass('phabricator-search-result-box');
257
264
} else {
258
265
$results = null;
259
266
}
260
267
261
-
return $this->buildStandardPageResponse(
268
+
269
+
return $this->buildApplicationPage(
262
270
array(
263
271
$search_panel,
264
272
$results,
265
273
),
266
274
array(
267
-
'title' => 'Search Results',
275
+
'title' => pht('Search Results'),
276
+
'device' => true,
277
+
'dust' => true,
268
278
));
269
279
}
270
280
+6
-10
webroot/rsrc/css/application/search/search-results.css
+6
-10
webroot/rsrc/css/application/search/search-results.css
···
2
2
* @provides phabricator-search-results-css
3
3
*/
4
4
5
-
.phabricator-search-result-list {
6
-
padding: 1em 3em 2em;
7
-
}
8
-
9
5
.phabricator-search-result {
10
6
margin: 4px 0 16px;
7
+
}
8
+
9
+
.device-phone .phabricator-search-result-box .phui-box {
10
+
margin: 20px 0;
11
11
}
12
12
13
13
.phabricator-search-result .result-image {
···
15
15
float: left;
16
16
width: 50px;
17
17
height: 50px;
18
-
}
19
-
20
-
.phabricator-search-result .result-desc {
21
-
margin-left: 58px;
18
+
margin-right: 10px;
22
19
}
23
20
24
21
.phabricator-search-result .result-type {
25
-
color: #888888;
26
-
font-size: 11px;
27
22
margin-top: 4px;
23
+
word-break: break-word;
28
24
}
29
25
30
26
.phabricator-search-result .result-name {